From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64A11C43461 for ; Mon, 14 Sep 2020 11:32:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1A029216C4 for ; Mon, 14 Sep 2020 11:32:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600083163; bh=LD8gKfq3+M60A9fkVwtz5N1wN5RFsUcksTxvGuoEBr4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=l5z55qy0rswaIsS13P6FbdB7A/rkEKS5tGuKZ61dMRoPbXrVAZl4TT9I1JNhq/lz3 V0TxPlaqnxMoyqY0j+Ii9eb4wv1v8XekvH8WIzzA9tpsSqwu8YD7pgT6QNdm4iREop 5MTCFm+hg1WjDtjcKungiINQ+9AY/laS0yIzO1VY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726062AbgINLcl (ORCPT ); Mon, 14 Sep 2020 07:32:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:49124 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726076AbgINL2J (ORCPT ); Mon, 14 Sep 2020 07:28:09 -0400 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B185D216C4; Mon, 14 Sep 2020 11:28:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600082888; bh=LD8gKfq3+M60A9fkVwtz5N1wN5RFsUcksTxvGuoEBr4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rCXdm3mH4nZTgySe0Df0IfxBSbZSiJeZOD3cinDUh6HQHt/AZE/IuWIZ05PGlegVy Q9lkl/AGuTd5Z9Thoapgv8scMIg5OFQ277Cf4Xczsvlzyc0DD0OdzIn9dAlcU/fdk7 5SipduQ6w15WyHR6gsWFZWNakkNN3pKiB9OimdvM= Date: Mon, 14 Sep 2020 12:28:04 +0100 From: Will Deacon To: Mark Salter Cc: Mark Rutland , Khuong Dinh , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] drivers/perf: xgene_pmu: Fix uninitialized resource struct Message-ID: <20200914112803.GA24312@willie-the-truck> References: <20200913174536.207265-1-msalter@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200913174536.207265-1-msalter@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 13, 2020 at 01:45:36PM -0400, Mark Salter wrote: > @@ -1483,11 +1473,23 @@ xgene_pmu_dev_ctx *acpi_get_pmu_hw_inf(struct xgene_pmu *xgene_pmu, > return NULL; > > INIT_LIST_HEAD(&resource_list); > - rc = acpi_dev_get_resources(adev, &resource_list, > - acpi_pmu_dev_add_resource, &res); > + rc = acpi_dev_get_resources(adev, &resource_list, NULL, NULL); > + if (rc <= 0) { > + dev_err(dev, "PMU type %d: No resources found\n", type); > + return NULL; > + } > + > + list_for_each_entry(rentry, &resource_list, node) { > + if (resource_type(rentry->res) == IORESOURCE_MEM) { > + res = *rentry->res; > + rentry = NULL; > + break; > + } > + } > acpi_dev_free_resource_list(&resource_list); > - if (rc < 0) { > - dev_err(dev, "PMU type %d: No resource address found\n", type); > + > + if (rentry) { I'm curious as to why you've had to change the failure logic here, setting rentry to NULL instead of checking 'rentry->res' like the TX2 driver (which I don't immediately understand at first glance). Will