From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D390C43461 for ; Mon, 14 Sep 2020 12:37:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D3C2A207EA for ; Mon, 14 Sep 2020 12:37:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="NcOJCe33" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726517AbgINMh2 (ORCPT ); Mon, 14 Sep 2020 08:37:28 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:57240 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726534AbgINMeu (ORCPT ); Mon, 14 Sep 2020 08:34:50 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 08EBq8Dx109058; Mon, 14 Sep 2020 06:52:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1600084328; bh=GGmby2jfJvMZfUC//Z+YkKOnqAazTLu+VDZkMWF+0Tk=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=NcOJCe33lP5xnwFH4rCT2WwQZs54W7XYs5zmGnWVlpNz1d1qhprqkSBxzI68coFNy 6Ar+cZnFDq2ilKQt8hx22pk3xcbFQiPgzBek9EPF/+jR5JT8RpmQIb1m0wGRw0HwG3 qQggZ8QmRpl2TYeWvSEqc7tHlKE+Hvo+8iyTzxf4= Received: from DFLE103.ent.ti.com (dfle103.ent.ti.com [10.64.6.24]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 08EBq83l111966 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 14 Sep 2020 06:52:08 -0500 Received: from DFLE111.ent.ti.com (10.64.6.32) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Mon, 14 Sep 2020 06:52:07 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Mon, 14 Sep 2020 06:52:07 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 08EBq7Oq038271; Mon, 14 Sep 2020 06:52:07 -0500 Date: Mon, 14 Sep 2020 06:52:07 -0500 From: Nishanth Menon To: Kishon Vijay Abraham I CC: Rob Herring , Tero Kristo , , , Subject: Re: [RESEND PATCH 1/2] arm64: dts: ti: k3-j721e-main: Add PCIe device tree nodes Message-ID: <20200914115207.wq4pmgrszhtgctdu@akan> References: <20200901140628.8800-1-kishon@ti.com> <20200901140628.8800-2-kishon@ti.com> <20200901145204.ayybrzqjcfhiqnfq@akan> <5f23246a-a9d7-495d-a4ec-d392ad95a450@ti.com> <4b17cace-09d5-af8c-6e7f-9358cfdceb4d@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16:53-20200914, Kishon Vijay Abraham I wrote: > Hi Rob, > > On 02/09/20 1:07 pm, Kishon Vijay Abraham I wrote: > > Hi Rob, > > > > On 02/09/20 10:24 am, Kishon Vijay Abraham I wrote: > >> Hi Nishanth, > >> > >> On 01/09/20 8:22 pm, Nishanth Menon wrote: > >>> On 19:36-20200901, Kishon Vijay Abraham I wrote: > >>>> Add PCIe device tree node (both RC and EP) for the four > >>>> PCIe instances here. > >>>> > >>>> Signed-off-by: Kishon Vijay Abraham I > >>>> --- > >>>>   arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 218 > >>>> ++++++++++++++++++++++ > >>>>   arch/arm64/boot/dts/ti/k3-j721e.dtsi      |   5 +- > >>>>   2 files changed, 222 insertions(+), 1 deletion(-) > >>> > >>> > >>> Did you look at the diff of the dtbs_check before and after this > >>> series? I see: https://pastebin.ubuntu.com/p/9fyfrTjx9M/ > >> > >> I didn't see any errors when I checked for individual bindings > >> a0393678@a0393678-ssd:~/repos/linux$ mkconfig64 dtbs_check > >> DT_SCHEMA_FILES="Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml" > >> > >>    SCHEMA  Documentation/devicetree/bindings/processed-schema.yaml > >>    DTC     arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml > >>    DTC     arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml > >>    CHECK   arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml > >>    CHECK   arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml > >> a0393678@a0393678-ssd:~/repos/linux$ mkconfig64 dtbs_check > >> DT_SCHEMA_FILES="Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml" > >> > >>    SCHEMA  Documentation/devicetree/bindings/processed-schema.yamlsimple-bus > >>    DTC     arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml > >>    DTC     arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml > >>    CHECK   arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml > >>    CHECK   arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml > > > > Can you give hint on why I get ranges is too long error > > https://pastebin.ubuntu.com/p/cPm2tg3dcV/ which I give mkconfig64 > > dtbs_check but don't see an error when I include "DT_SCHEMA_FILES"? > > I debugged this and looks like PCIe "ranges" property conflicts with > simple-bus. > > A diff like below helps to solve the issue > diff --git a/schemas/simple-bus.yaml b/schemas/simple-bus.yaml > index 248ac9d..ed818ef 100644 > --- a/schemas/simple-bus.yaml > +++ b/schemas/simple-bus.yaml > @@ -39,7 +39,7 @@ patternProperties: > oneOf: > - items: > minItems: 3 > - maxItems: 6 > + maxItems: 7 > minItems: 0 > maxItems: 1024 > - $ref: "types.yaml#/definitions/flag" > > If this looks right to you, I can post a patch for it. Without fixing > this we would see false errors for PCIe DT nodes. https://github.com/devicetree-org/dt-schema/commit/3baf308b01786788e3ccb9824fce6d7136b21214 Part of v2020.08.1? Am i missing something? -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D