From: David Miller <davem@davemloft.net>
To: mdf@kernel.org
Cc: snelson@pensando.io, mst@redhat.com, hkallweit1@gmail.com,
netdev@vger.kernel.org, linux-parisc@vger.kernel.org,
linux-kernel@vger.kernel.org, moritzf@google.com
Subject: Re: [PATCH net-next v2 0/3] First bunch of Tulip cleanups
Date: Tue, 15 Sep 2020 15:47:58 -0700 (PDT) [thread overview]
Message-ID: <20200915.154758.399614089931643151.davem@davemloft.net> (raw)
In-Reply-To: <20200915042452.26155-1-mdf@kernel.org>
From: Moritz Fischer <mdf@kernel.org>
Date: Mon, 14 Sep 2020 21:24:49 -0700
> This series is the first bunch of minor cleanups for the de2104x driver
> to make it look and behave more like a modern driver.
>
> These changes replace some of the non-devres versions with devres
> versions of functions to simplify the error paths.
>
> Next up after this will be the ioremap part.
I really don't consider a "conversion" over to devres for older drivers
a suitable cleanup.
There are no resource handling bugs you are fixing, the driver uses
the APIs it uses correctly, and the coding style is reasonable.
Therefore, I'm sorry I'm not applying these changes.
prev parent reply other threads:[~2020-09-15 22:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 4:24 Moritz Fischer
2020-09-15 4:24 ` [PATCH net-next v2 1/3] net: dec: tulip: de2104x: Replace alloc_etherdev by devm_alloc_etherdev Moritz Fischer
2020-09-15 4:24 ` [PATCH net-next v2 2/3] net: dec: tulip: de2104x: Replace pci_enable_device with devres version Moritz Fischer
2020-09-15 4:24 ` [PATCH net-next v2 3/3] net: dec: tulip: de2104x: Replace kmemdup() with devm_kmempdup() Moritz Fischer
2020-09-15 22:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915.154758.399614089931643151.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=moritzf@google.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=snelson@pensando.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®