From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9EFFC433E2 for ; Tue, 15 Sep 2020 16:51:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8F76820809 for ; Tue, 15 Sep 2020 16:51:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727767AbgIOQuS (ORCPT ); Tue, 15 Sep 2020 12:50:18 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:48059 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727527AbgIOQAz (ORCPT ); Tue, 15 Sep 2020 12:00:55 -0400 Received: from ip5f5af089.dynamic.kabel-deutschland.de ([95.90.240.137] helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1kIDAe-00057M-PQ; Tue, 15 Sep 2020 15:47:04 +0000 Date: Tue, 15 Sep 2020 17:47:04 +0200 From: Christian Brauner To: Miaohe Lin Cc: akpm@linux-foundation.org, peterz@infradead.org, mingo@kernel.org, ebiederm@xmission.com, christian@kellner.me, surenb@google.com, areber@redhat.com, shakeelb@google.com, cyphar@cyphar.com, tglx@linutronix.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fork: Use helper function mapping_allow_writable() in dup_mmap() Message-ID: <20200915154704.lvboxqqgfokbhidc@wittgenstein> References: <20200913092415.24408-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200913092415.24408-1-linmiaohe@huawei.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 13, 2020 at 05:24:15AM -0400, Miaohe Lin wrote: > Use helper function mapping_allow_writable() to atomic_inc i_mmap_writable. > > Signed-off-by: Miaohe Lin > --- Hey Miaohe, Thanks for the patch! Per se there's nothing against using a proper helper when it exists. But it has already been pointed out that this needs a proper commit message with more rationale. But I'm otherwise happy to take this. Thanks! Christian