From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 171AAC43461 for ; Wed, 16 Sep 2020 00:49:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CBC5E2076B for ; Wed, 16 Sep 2020 00:49:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600217345; bh=WyF3P7Aqu/5jOAe8bgWDIiaXqgmy/5Hi7Hqfi1YYGxM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=ecXru2oGDEpH8awgr+C1l4oDSbB0FbGZZSggJKK8W5IBZczioiuychf+9W3F7q6xi IFqfszMjuNAaw9olv4i60JGo5e5nwNSwwc9N9zllQLxmnEokmt9d4P9NksWa0lSnCq afsKN6lk9Z7OH+4eI/5Xsh8R9T2or+aHrdubdcjY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726912AbgIPAtE (ORCPT ); Tue, 15 Sep 2020 20:49:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:45392 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726453AbgIPAs7 (ORCPT ); Tue, 15 Sep 2020 20:48:59 -0400 Received: from X1 (unknown [67.22.170.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4FC9420770; Wed, 16 Sep 2020 00:48:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600217336; bh=WyF3P7Aqu/5jOAe8bgWDIiaXqgmy/5Hi7Hqfi1YYGxM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bVYT1hmrZROX6bU3uwWE4x610xoug0ite08lGt2IcjKJ6EyBQJmob8oF/a7+334XQ 70TOEGz0Btq6bzmP3GD+86mAZXStilE+tuTXtJArwowTBMTdNdU0NWgFPUAFg3s93/ t07TYXV5YLomk2UW96M71H3gFsP6l2Ufvl5+iH6o= Date: Tue, 15 Sep 2020 17:48:55 -0700 From: Andrew Morton To: Cc: , Subject: Re: [PATCH] mm/page_alloc.c: variable type of 'progress' should be 'unsigned long' Message-Id: <20200915174855.822d866316948aadb8193e9b@linux-foundation.org> In-Reply-To: <20200915104620.20582-1-yanfei.xu@windriver.com> References: <20200915104620.20582-1-yanfei.xu@windriver.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 15 Sep 2020 18:46:20 +0800 wrote: > From: Yanfei Xu > > try_to_free_pages returns the number of pages reclaimed, and the type of > returns is 'unsigned long'. So we should use a matched type for storing > it. > __perform_reclaim() returns an int, so this change is fairly pointless. However __perform_reclaim()'s single caller expects it to return unsigned long, so including that change in this patch would make more sense.