From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CED3C43461 for ; Tue, 15 Sep 2020 21:49:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3D7132078E for ; Tue, 15 Sep 2020 21:49:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CWkcaAq9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728101AbgIOVtW (ORCPT ); Tue, 15 Sep 2020 17:49:22 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:31087 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728017AbgIOVsQ (ORCPT ); Tue, 15 Sep 2020 17:48:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600206483; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uyWI3nYNMIb9lFM4sTwGsqsaOvjrxBPpZMj9bkIjmjE=; b=CWkcaAq9m5Mf/EOTut9RWggw9/kXNbzKzqI19wbJS4NMnCszgkvzB6N27SHEh5Umv92cX0 TJmUX8rrTcMxEEKVHNFksAwaq8W0Ve3dcc9QdSvHM6zwpHZfmNuxrsP7JLAW1pKiqWWH1v 7v7DHX9SW9ghAYDs4KO4ZafgzzGeFkM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-174-GPcxzim-McmD6Exr6iPevA-1; Tue, 15 Sep 2020 17:48:01 -0400 X-MC-Unique: GPcxzim-McmD6Exr6iPevA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 05A63192C8D4; Tue, 15 Sep 2020 21:47:46 +0000 (UTC) Received: from treble (ovpn-112-136.rdu2.redhat.com [10.10.112.136]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 499231C4; Tue, 15 Sep 2020 21:47:45 +0000 (UTC) Date: Tue, 15 Sep 2020 16:47:43 -0500 From: Josh Poimboeuf To: Mark Wielaard Cc: peterz@infradead.org, Hugh Dickins , linux-kernel@vger.kernel.org, x86@kernel.org Subject: Re: Static call dependency on libelf version? Message-ID: <20200915214743.aavqreiw7dh6s3xj@treble> References: <20200915093016.GV1362448@hirez.programming.kicks-ass.net> <20200915141701.j5fnir63trpwqbfp@treble> <38388294c6ad7bf4abdb1b9a0bac9af5224c8fa6.camel@klomp.org> <20200915150229.75ilnm32a5fnjbja@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200915150229.75ilnm32a5fnjbja@treble> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 15, 2020 at 10:02:31AM -0500, Josh Poimboeuf wrote: > On Tue, Sep 15, 2020 at 04:38:02PM +0200, Mark Wielaard wrote: > > Hi Josh, > > > > On Tue, 2020-09-15 at 09:17 -0500, Josh Poimboeuf wrote: > > > On Tue, Sep 15, 2020 at 01:24:17PM +0200, Mark Wielaard wrote: > > > > But all this is for ancient versions of elfutils libelf. So it is hard > > > > to say and my memory might be failing. If someone can confirm 0.158 > > > > (which is 6 years old) works fine I would pick that as minimum version, > > > > otherwise simply go with 0.168 which is 4 years old and should be on > > > > most systems by now. > > > > > > I just discovered elf_version(), I assume that would allow us to check > > > and enforce the libelf version? > > > > No, sorry. That is for the ELF file format version, which is and has > > always been version 1 (and I suspect it will be for the next 20 > > years). > > Oh, right :-) > > > There is /usr/include/elfutils/version.h which provides a > > _ELFUTILS_PREREQ(major, minor) macro if you need something during > > compile time. > > Nice, I'll try that. Confirmed that 0.158 fixes it. I'll enforce that as a minimum. Thanks! -- Josh