From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 058DEC43461 for ; Wed, 16 Sep 2020 07:31:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C7F0620809 for ; Wed, 16 Sep 2020 07:31:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726467AbgIPHbG (ORCPT ); Wed, 16 Sep 2020 03:31:06 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:33316 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726161AbgIPHbF (ORCPT ); Wed, 16 Sep 2020 03:31:05 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id A0A851C0B76; Wed, 16 Sep 2020 09:31:00 +0200 (CEST) Date: Wed, 16 Sep 2020 09:31:00 +0200 From: Pavel Machek To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Jonathan Cameron , Angelo Compagnucci , Sasha Levin Subject: Re: [PATCH 4.19 09/78] iio: adc: mcp3422: fix locking on error path Message-ID: <20200916073100.GA32537@duo.ucw.cz> References: <20200915140633.552502750@linuxfoundation.org> <20200915140634.010489871@linuxfoundation.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="huq684BweRXVnRxX" Content-Disposition: inline In-Reply-To: <20200915140634.010489871@linuxfoundation.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --huq684BweRXVnRxX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > [ Upstream commit a139ffa40f0c24b753838b8ef3dcf6ad10eb7854 ] >=20 > Reading from the chip should be unlocked on error path else the lock > could never being released. >=20 > Fixes: 07914c84ba30 ("iio: adc: Add driver for Microchip MCP3422/3/4 high= resolution ADC") > Fixes: 3f1093d83d71 ("iio: adc: mcp3422: fix locking scope") Well, 3f1093d83d71 is only applied later in the stable series, so this introduces spurious unlock. Ideally this should go just after 3f1093d83d71 ("iio: adc: mcp3422: fix locking scope"). Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --huq684BweRXVnRxX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCX2G/NAAKCRAw5/Bqldv6 8ojkAJ0YrKaZTyrNMwgKA4OWczZiLBQAyACgh4hmA2LsPIoggr+YrlpdlKzXMdk= =77CW -----END PGP SIGNATURE----- --huq684BweRXVnRxX--