From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0AE0C43461 for ; Wed, 16 Sep 2020 20:11:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7BD9421582 for ; Wed, 16 Sep 2020 20:11:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728310AbgIPULM (ORCPT ); Wed, 16 Sep 2020 16:11:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727193AbgIPRdl (ORCPT ); Wed, 16 Sep 2020 13:33:41 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D355C0073E2 for ; Wed, 16 Sep 2020 06:58:23 -0700 (PDT) Received: from bigeasy by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1kIXwv-0004I7-Ps; Wed, 16 Sep 2020 15:58:17 +0200 Date: Wed, 16 Sep 2020 15:58:17 +0200 From: Sebastian Andrzej Siewior To: peterz@infradead.org Cc: mingo@kernel.org, vincent.guittot@linaro.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bristot@redhat.com, swood@redhat.com, valentin.schneider@arm.com Subject: Re: [PATCH 2/2] sched/hotplug: Ensure only per-cpu kthreads run during hotplug Message-ID: <20200916135817.3djsqmziqvzo6hmq@flow> References: <20200911081745.214686199@infradead.org> <20200911082536.528661716@infradead.org> <20200916101845.5ikjhfk27bgvs3pe@flow> <20200916121020.GP2674@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200916121020.GP2674@hirez.programming.kicks-ass.net> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-09-16 14:10:20 [+0200], peterz@infradead.org wrote: squeeze that in please: diff --git a/kernel/sched/core.c b/kernel/sched/core.c index a4fe22b8b8418..bed3cd28af578 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -6866,7 +6866,7 @@ static int __balance_push_cpu_stop(void *arg) raw_spin_lock_irq(&p->pi_lock); rq_lock(rq, &rf); - update_rq_clock(); + update_rq_clock(rq); if (task_rq(p) == rq && task_on_rq_queued(p)) { cpu = select_fallback_rq(rq->cpu, p); and count me in :) Sebastian