From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC959C43461 for ; Wed, 16 Sep 2020 21:02:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69C8C206D4 for ; Wed, 16 Sep 2020 21:02:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600290134; bh=acejB/prIRtsxQWg9QojyBj2lNUB1jdZy+zS/DMW7k8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=fPvo5rRx4Ui7gWaTeI4UoVkQgXw6pevXAw/55s2Phi5B3RLs9xXPY6M25P9T8g94K zRXaTjZlRPDs/LaaKqQ2d8rzcD/PNs5u/ezS8XcWllj7y5bjvxhEuel5DMzYwJcsRC jXZiBs9Jbx6S3r0t0iQN/thA3mkcLMygyPDcdJJ8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728575AbgIPVCH (ORCPT ); Wed, 16 Sep 2020 17:02:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:43072 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726216AbgIPQaX (ORCPT ); Wed, 16 Sep 2020 12:30:23 -0400 Received: from localhost (unknown [122.172.186.249]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3E84F22245; Wed, 16 Sep 2020 14:29:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600266577; bh=acejB/prIRtsxQWg9QojyBj2lNUB1jdZy+zS/DMW7k8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c/G3ibtpL/helsck+Eq0cptCROJFScHN/nQ/IkiLTpfKInK2uYM5Yn+VH8e4+GNGp 6gDbCrwtBRP+LI1uU+hJMCbKiug6fXVyOHA7jtcAtkVGb1tZSStL9V14CEv1D4ol3j +rMOgaGhVEQ5nOf3CMwF2kjFH6y5qpfXEaRV61rI= Date: Wed, 16 Sep 2020 19:59:29 +0530 From: Vinod Koul To: Pierre-Louis Bossart Cc: Srinivas Kandagatla , yung-chuan.liao@linux.intel.com, sanyog.r.kale@intel.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] soundwire: qcom: clear BIT FIELDs before value set. Message-ID: <20200916142929.GR2968@vkoul-mobl> References: <20200916092125.30898-1-srinivas.kandagatla@linaro.org> <20200916092125.30898-2-srinivas.kandagatla@linaro.org> <20200916124634.GM2968@vkoul-mobl> <24401c7c-b12c-0924-9d8f-fde633d15918@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <24401c7c-b12c-0924-9d8f-fde633d15918@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16-09-20, 08:18, Pierre-Louis Bossart wrote: > > > > According to usage (bitfields.h) of REG_FIELDS, > > > Modify is: > > > reg &= ~REG_FIELD_C; > > > reg |= FIELD_PREP(REG_FIELD_C, c); > > > if this is indeed the case, all the code in cadence_master.c is also broken, > e.g: > > dpn_config = cdns_readl(cdns, dpn_config_off); > > dpn_config |= FIELD_PREP(CDNS_DPN_CONFIG_WL, (p_params->bps - 1)); > dpn_config |= FIELD_PREP(CDNS_DPN_CONFIG_PORT_FLOW, p_params->flow_mode); > dpn_config |= FIELD_PREP(CDNS_DPN_CONFIG_PORT_DAT, p_params->data_mode); This should be replaced with u32_replace_bits(), i am sending the fix > > > Gah. should have caught this :( -- ~Vinod