From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C404C43461 for ; Wed, 16 Sep 2020 18:20:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E8A3920731 for ; Wed, 16 Sep 2020 18:20:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727893AbgIPSUs (ORCPT ); Wed, 16 Sep 2020 14:20:48 -0400 Received: from 6.mo7.mail-out.ovh.net ([188.165.39.218]:43652 "EHLO 6.mo7.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727653AbgIPSUk (ORCPT ); Wed, 16 Sep 2020 14:20:40 -0400 X-Greylist: delayed 6468 seconds by postgrey-1.27 at vger.kernel.org; Wed, 16 Sep 2020 14:20:40 EDT Received: from player738.ha.ovh.net (unknown [10.108.42.73]) by mo7.mail-out.ovh.net (Postfix) with ESMTP id 423DB176E52 for ; Wed, 16 Sep 2020 18:31:18 +0200 (CEST) Received: from etezian.org (213-243-141-64.bb.dnainternet.fi [213.243.141.64]) (Authenticated sender: andi@etezian.org) by player738.ha.ovh.net (Postfix) with ESMTPSA id 58AA51654073D; Wed, 16 Sep 2020 16:31:06 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-99G003434935c3-d5be-4bfb-9d38-1f2210c8509c, E220774DB7FC1891A64BD699B7E3BDDD469A7482) smtp.auth=andi@etezian.org Date: Wed, 16 Sep 2020 19:31:05 +0300 From: Andi Shyti To: YueHaibing Cc: dmitry.torokhov@gmail.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, andi@etezian.org, javier@osg.samsung.com, robh@kernel.org, linux-input@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] Input: stmfts - Fix a & vs && typo Message-ID: <20200916163105.GB50769@jack.zhora.eu> References: <20200916141941.16684-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200916141941.16684-1-yuehaibing@huawei.com> X-Ovh-Tracer-Id: 4455748883065979445 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedujedrtddvgddutddvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughiucfuhhihthhiuceorghnughisegvthgviihirghnrdhorhhgqeenucggtffrrghtthgvrhhnpedtgfduudfhfeeuueejfeeihedtfeetgfegveehgfeuleelhfduteegieekudeifeenucfkpheptddrtddrtddrtddpvddufedrvdegfedrudeguddrieegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpqdhouhhtpdhhvghlohepphhlrgihvghrjeefkedrhhgrrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegrnhguihesvghtvgiiihgrnhdrohhrghdprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrgh Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi YueHaibing, On Wed, Sep 16, 2020 at 10:19:41PM +0800, YueHaibing wrote: > In stmfts_sysfs_hover_enable_write(), we should check > value and sdata->hover_enabled is all true. > > Fixes: 78bcac7b2ae1 ("Input: add support for the STMicroelectronics FingerTip touchscreen") > Signed-off-by: YueHaibing Reviewed-by: Andi Shyti Thanks, Andi