From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24083C433E2 for ; Thu, 17 Sep 2020 03:48:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D59102080C for ; Thu, 17 Sep 2020 03:48:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726201AbgIQDsh (ORCPT ); Wed, 16 Sep 2020 23:48:37 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:12772 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726118AbgIQDs0 (ORCPT ); Wed, 16 Sep 2020 23:48:26 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id DE49E15AE79EDA874EF2; Thu, 17 Sep 2020 11:32:18 +0800 (CST) Received: from DESKTOP-8RFUVS3.china.huawei.com (10.174.185.226) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.487.0; Thu, 17 Sep 2020 11:32:08 +0800 From: Zenghui Yu To: , CC: , , , Zenghui Yu Subject: [PATCH 2/2] vfio/pci: Remove bardirty from vfio_pci_device Date: Thu, 17 Sep 2020 11:31:28 +0800 Message-ID: <20200917033128.872-2-yuzenghui@huawei.com> X-Mailer: git-send-email 2.23.0.windows.1 In-Reply-To: <20200917033128.872-1-yuzenghui@huawei.com> References: <20200917033128.872-1-yuzenghui@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.174.185.226] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It isn't clear what purpose the @bardirty serves. It might be used to avoid the unnecessary vfio_bar_fixup() invoking on a user-space BAR read, which is not required when bardirty is unset. The variable was introduced in commit 89e1f7d4c66d ("vfio: Add PCI device driver") but never actually used, so it shouldn't be that important. Remove it. Signed-off-by: Zenghui Yu --- drivers/vfio/pci/vfio_pci_config.c | 7 ------- drivers/vfio/pci/vfio_pci_private.h | 1 - 2 files changed, 8 deletions(-) diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci_config.c index d98843feddce..e93b287fea02 100644 --- a/drivers/vfio/pci/vfio_pci_config.c +++ b/drivers/vfio/pci/vfio_pci_config.c @@ -507,8 +507,6 @@ static void vfio_bar_fixup(struct vfio_pci_device *vdev) *vbar &= cpu_to_le32((u32)mask); } else *vbar = 0; - - vdev->bardirty = false; } static int vfio_basic_config_read(struct vfio_pci_device *vdev, int pos, @@ -633,9 +631,6 @@ static int vfio_basic_config_write(struct vfio_pci_device *vdev, int pos, } } - if (is_bar(offset)) - vdev->bardirty = true; - return count; } @@ -1697,8 +1692,6 @@ int vfio_config_init(struct vfio_pci_device *vdev) if (ret) goto out; - vdev->bardirty = true; - /* * XXX can we just pci_load_saved_state/pci_restore_state? * may need to rebuild vconfig after that diff --git a/drivers/vfio/pci/vfio_pci_private.h b/drivers/vfio/pci/vfio_pci_private.h index 61ca8ab165dc..dc96a0fda548 100644 --- a/drivers/vfio/pci/vfio_pci_private.h +++ b/drivers/vfio/pci/vfio_pci_private.h @@ -122,7 +122,6 @@ struct vfio_pci_device { bool virq_disabled; bool reset_works; bool extended_caps; - bool bardirty; bool has_vga; bool needs_reset; bool nointx; -- 2.19.1