From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2A0CC433E2 for ; Thu, 17 Sep 2020 08:00:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4BD6B20665 for ; Thu, 17 Sep 2020 08:00:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="xH84vWDs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726199AbgIQIAK (ORCPT ); Thu, 17 Sep 2020 04:00:10 -0400 Received: from esa5.microchip.iphmx.com ([216.71.150.166]:12410 "EHLO esa5.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726312AbgIQH7p (ORCPT ); Thu, 17 Sep 2020 03:59:45 -0400 X-Greylist: delayed 430 seconds by postgrey-1.27 at vger.kernel.org; Thu, 17 Sep 2020 03:59:44 EDT DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1600329584; x=1631865584; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=soGW+pknjaksN08RJ7LPk0ndAYp4pwodv9WM2rL7awQ=; b=xH84vWDsBMerjf4jlpJQplhyPcyh42/sziUXFknvrneZBlz4bRpCPqph ceYbBIf/u1wvC1usP2dsYyJo8J90NR5ykEQM0sSRHHgUvxxGAH8j2xABc aQ452PrrEUPReUjAW3y0Lnt/ObEM5PbfOAnl4SUFbMI8wKf9Orrd6zWmn 3UCHLWPCdB/ENKEBPafCD16w4glXmJnxmr6HoFT/gF4hehSxEbsH+J3Zu B+pypYBjX5vblT1bng5mIY1MEOn09quRF26m2MNN5wNzzwj/3QCJAgWy5 DR+ebQGXvfmdj+SkQuO38xEDQqcXAVmfROlVC1jUI4ABjFVw9u/tzFdPZ w==; IronPort-SDR: aQjr5gh0DdIuLQSBqrioZhf/IlVjfM2bc7tzY7wh5eIXW/WLU3XtGnxxUedOv4W8W8AR6/Lycm v4dbgfEldFXsybFqTNPSRj/XZC1Ie2LRirq3d1Dc5f1O5NQoSaLyXVrLddLeXHNDVSmZ0vZ6WO uyOkaGqkGCl0/9eteH/aw6VT111LLcO4d6hCMGIOwuZIBbzzjc7tovBfIOUBSTt9jpCrTOralY Ytn/4KdEFMwWkXhMOkgx7/XmFCHC73hs7SxqTXk4O1QK117/ZZ3PCb0EFYcqd0jBgqk1NEG8da wFc= X-IronPort-AV: E=Sophos;i="5.76,436,1592895600"; d="scan'208";a="91346697" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 17 Sep 2020 00:52:33 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Thu, 17 Sep 2020 00:51:56 -0700 Received: from atudor-ThinkPad-T470p.local (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.1979.3 via Frontend Transport; Thu, 17 Sep 2020 00:51:54 -0700 From: Tudor Ambarus To: , , , CC: , , "Tudor Ambarus" Subject: [PATCH 0/3] mtd: rawnand: Fix HW ECC handling Date: Thu, 17 Sep 2020 10:52:10 +0300 Message-ID: <20200917075213.532161-1-tudor.ambarus@microchip.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix a wrongful fallthrough NAND_ECC_SOFT when a valid HW ECC is available. Follow with two patches to make the code more readable. Following error was seen in case of a valid HW ECC: nand: device found, Manufacturer ID: 0x2c, Chip ID: 0xda nand: Micron MT29F2G08ABAEAWP nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 ------------[ cut here ]------------ WARNING: CPU: 0 PID: 1 at drivers/mtd/nand/raw/nand_base.c:5148 nand_scan_with_ids+0x12b8/0x1674 Modules linked in: CPU: 0 PID: 1 Comm: swapper Not tainted 5.9.0-rc5-next-20200914 #2 Hardware name: Atmel SAMA5 [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [] (show_stack) from [] (__warn+0xb8/0xd0) [] (__warn) from [] (warn_slowpath_fmt+0x60/0xbc) [] (warn_slowpath_fmt) from [] (nand_scan_with_ids+0x12b8/0x1674) [] (nand_scan_with_ids) from [] (atmel_nand_controller_add_nand+0x54/0x100) [] (atmel_nand_controller_add_nand) from [] (atmel_nand_controller_add_nands+0x31c/0x60c) [] (atmel_nand_controller_add_nands) from [] (atmel_hsmc_nand_controller_probe+0x188/0x284) [] (atmel_hsmc_nand_controller_probe) from [] (atmel_nand_controller_probe+0x54/0x134) [] (atmel_nand_controller_probe) from [] (platform_drv_probe+0x48/0x98) [] (platform_drv_probe) from [] (really_probe+0x1e0/0x3b8) [] (really_probe) from [] (driver_probe_device+0x5c/0xb4) [] (driver_probe_device) from [] (bus_for_each_drv+0x80/0xc4) [] (bus_for_each_drv) from [] (__device_attach+0xe0/0x14c) [] (__device_attach) from [] (bus_probe_device+0x84/0x8c) [] (bus_probe_device) from [] (device_add+0x408/0x774) [] (device_add) from [] (of_platform_device_create_pdata+0x98/0xd4) [] (of_platform_device_create_pdata) from [] (of_platform_bus_create+0x190/0x220) [] (of_platform_bus_create) from [] (of_platform_populate+0x60/0xc0) [] (of_platform_populate) from [] (atmel_ebi_probe+0x358/0x530) [] (atmel_ebi_probe) from [] (platform_drv_probe+0x48/0x98) [] (platform_drv_probe) from [] (really_probe+0x1e0/0x3b8) [] (really_probe) from [] (driver_probe_device+0x5c/0xb4) [] (driver_probe_device) from [] (device_driver_attach+0x58/0x60) [] (device_driver_attach) from [] (__driver_attach+0x58/0xcc) [] (__driver_attach) from [] (bus_for_each_dev+0x74/0xb4) [] (bus_for_each_dev) from [] (bus_add_driver+0xf4/0x1d8) [] (bus_add_driver) from [] (driver_register+0x74/0x108) [] (driver_register) from [] (__platform_driver_probe+0x68/0xc8) [] (__platform_driver_probe) from [] (do_one_initcall+0x7c/0x1cc) [] (do_one_initcall) from [] (kernel_init_freeable+0x15c/0x1c0) [] (kernel_init_freeable) from [] (kernel_init+0x8/0x114) [] (kernel_init) from [] (ret_from_fork+0x14/0x2c) Exception stack(0xcf427fb0 to 0xcf427ff8) 7fa0: 00000000 00000000 00000000 00000000 7fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 7fe0: 00000000 00000000 00000000 00000000 00000013 00000000 ---[ end trace 7fad321bf58a54e1 ]--- atmel-nand-controller 10000000.ebi:nand-controller: NAND scan failed: -22 atmel-nand-controller: probe of 10000000.ebi:nand-controller failed with error -22 Tudor Ambarus (3): mtd: rawnand: Fix wrongful fallthrough NAND_ECC_SOFT mtd: rawnand: Introduce nand_set_ecc_on_host_ops() mtd: rawnand: Don't overwrite the error code from nand_set_ecc_soft_ops() drivers/mtd/nand/raw/nand_base.c | 134 ++++++++++++++++--------------- 1 file changed, 70 insertions(+), 64 deletions(-) -- 2.25.1