From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DB2EC433E2 for ; Thu, 17 Sep 2020 11:06:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1EB0C2075E for ; Thu, 17 Sep 2020 11:06:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600340805; bh=aPCEwcIAuMvYoCEBtOQo2eERHoS019qUBYLdVY0/hTk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=dL6vF7w7dsxI0O/bO6mccLG7iVzZEMuKGlnCdwHbCsdpssDK71/4E+yqIqmTGVUhb CVS4wF4v+dZkicvRzxx/MEKCXHt5mzbN4k4rTUk2BmGz+OlZsjL9ET/PMZljeUHm03 B7Jknm1appsOppmvipipaiVx1zD1JVE+UL4+Ez8Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726524AbgIQLGk (ORCPT ); Thu, 17 Sep 2020 07:06:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:38060 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726559AbgIQLDZ (ORCPT ); Thu, 17 Sep 2020 07:03:25 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D74522076D; Thu, 17 Sep 2020 11:01:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600340503; bh=aPCEwcIAuMvYoCEBtOQo2eERHoS019qUBYLdVY0/hTk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1ccLIq0l0KnciBSQeBF5gPuenyxYph0LJQ4FgwgULOzMRDnR8LzMTkkgaclkQ6UOy BHB6aUZLthOo8hUIvk2Cgr43XmGm9QSZr1+/9U9L1iBbPajP4pWOXKfFHocssoYmDM iXVEVmsro/blj+Bt9nPVVgCsq0g3ZRBa7MDjEk0k= Date: Thu, 17 Sep 2020 12:00:53 +0100 From: Mark Brown To: Alban Bedel Cc: linux-hwmon@vger.kernel.org, Jean Delvare , Guenter Roeck , Rob Herring , Liam Girdwood , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] hwmon: (lm75) Add regulator support Message-ID: <20200917110053.GA4755@sirena.org.uk> References: <20200917101819.32045-1-alban.bedel@aerq.com> <20200917101819.32045-4-alban.bedel@aerq.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fdj2RfSjLxBAspz7" Content-Disposition: inline In-Reply-To: <20200917101819.32045-4-alban.bedel@aerq.com> X-Cookie: If you fail to plan, plan to fail. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --fdj2RfSjLxBAspz7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Sep 17, 2020 at 12:18:19PM +0200, Alban Bedel wrote: > + data->vs = devm_regulator_get_optional(dev, "vs"); > + if (IS_ERR(data->vs)) { Unless the device can work without power you should not be using regulator_get_optional(). --fdj2RfSjLxBAspz7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl9jQeQACgkQJNaLcl1U h9B2Jwf9FsOfhx52XRbTX0EQlV1uzHXTjKYKY0f/VVzp1/NtZQjgJW/qzpGIstuH JgAoa98HRd+Dd7MSfrLgDepC1+7MHNaMlFL4Dv28/V9NkM9atu9dvxduwckp+1sR sIdeHldh7jw5Tmjz5dmKbKbWn17r5MX4eTR8pv1hZlKfCraIIVMq145NgBiV0q6R JurB8qhGznwolBc4hHz6X+rAyNo+ZrvE/hsfxtKaXVjziSQwgRopaSbXlD5pTYsD teudpthwvxrG9lg/HVY+WAaBhpNxHSLKfr7IMV1tptOqxRvnOKn+c+6/CicnpZiZ fDHkDqIsFPj98T7sHutzo79R6A6xHw== =XT8Y -----END PGP SIGNATURE----- --fdj2RfSjLxBAspz7--