From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Daniel Scally <djrscally@gmail.com>,
devel@driverdev.osuosl.org, robh@kernel.org,
jorhand@linux.microsoft.com, linux-media@vger.kernel.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
kieran.bingham@ideasonboard.com, kitakar@gmail.com,
bingbu.cao@intel.com, mchehab@kernel.org, davem@davemloft.net,
tian.shu.qiu@intel.com, yong.zhi@intel.com
Subject: Re: [RFC PATCH] Add bridge driver to connect sensors to CIO2 device via software nodes on ACPI platforms
Date: Thu, 17 Sep 2020 15:25:29 +0300 [thread overview]
Message-ID: <20200917122529.GJ3956970@smile.fi.intel.com> (raw)
In-Reply-To: <20200917104941.GP4282@kadam>
On Thu, Sep 17, 2020 at 01:49:41PM +0300, Dan Carpenter wrote:
> On Thu, Sep 17, 2020 at 01:33:43PM +0300, Sakari Ailus wrote:
> > > + int i, ret;
> >
> > unsigned int i
> >
>
> Why?
>
> For list iterators then "int i;" is best... For sizes then unsigned is
> sometimes best. Or if it's part of the hardware spec or network spec
> unsigned is best. Otherwise unsigned variables cause a ton of bugs.
> They're not as intuitive as signed variables. Imagine if there is an
> error in this loop and you want to unwind. With a signed variable you
> can do:
>
> while (--i >= 0)
> cleanup(&bridge.sensors[i]);
Ha-ha. It's actually a counter argument to your stuff because above is the same as
while (i--)
cleanup(&bridge.sensors[i]);
with pretty much unsigned int i.
> There are very few times where raising the type maximum from 2 billion
> to 4 billion fixes anything.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-09-17 12:39 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 21:36 Daniel Scally
2020-09-17 7:53 ` Greg KH
2020-09-17 9:47 ` Dan Scally
2020-09-17 10:15 ` Dan Carpenter
2020-09-17 10:24 ` Dan Scally
2020-09-17 13:28 ` Kieran Bingham
2020-09-17 14:08 ` Andy Shevchenko
2020-09-17 14:19 ` Kieran Bingham
2020-09-17 14:36 ` Andy Shevchenko
2020-09-17 9:34 ` Dan Carpenter
2020-09-17 10:19 ` Joe Perches
2020-09-18 22:50 ` Dan Scally
2020-09-17 10:33 ` Sakari Ailus
2020-09-17 10:49 ` Dan Carpenter
2020-09-17 12:25 ` Andy Shevchenko [this message]
2020-09-17 13:15 ` Dan Carpenter
2020-09-18 6:40 ` Sakari Ailus
2020-09-18 8:16 ` Dan Carpenter
2020-09-17 10:52 ` Dan Scally
2020-09-17 12:45 ` Andy Shevchenko
2020-09-17 13:36 ` Dan Scally
2020-09-17 14:14 ` Andy Shevchenko
2020-09-17 21:25 ` Daniel Scally
2020-09-17 14:44 ` Andy Shevchenko
2020-09-18 7:51 ` Sakari Ailus
2020-09-18 13:07 ` Andy Shevchenko
2020-09-21 13:33 ` Dan Scally
2020-09-21 14:33 ` Andy Shevchenko
2020-09-23 9:39 ` Dan Scally
2020-09-28 11:37 ` Dan Scally
2020-09-18 8:03 ` Dan Carpenter
2020-09-18 8:09 ` Dan Scally
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917122529.GJ3956970@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bingbu.cao@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=djrscally@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jorhand@linux.microsoft.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=kitakar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tian.shu.qiu@intel.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®