From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2709C433E2 for ; Thu, 17 Sep 2020 14:07:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5466720838 for ; Thu, 17 Sep 2020 14:07:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727335AbgIQOHb (ORCPT ); Thu, 17 Sep 2020 10:07:31 -0400 Received: from elvis.franken.de ([193.175.24.41]:43209 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727242AbgIQN6q (ORCPT ); Thu, 17 Sep 2020 09:58:46 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1kIuQi-0006iI-00; Thu, 17 Sep 2020 15:58:32 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 8E28CC0FCF; Thu, 17 Sep 2020 15:55:15 +0200 (CEST) Date: Thu, 17 Sep 2020 15:55:15 +0200 From: Thomas Bogendoerfer To: Thomas Gleixner , Ralf Baechle , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] MIPS: SNI: Fix spurious interrupts Message-ID: <20200917135515.GA12790@alpha.franken.de> References: <20200916135437.60572-1-tsbogend@alpha.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200916135437.60572-1-tsbogend@alpha.franken.de> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 16, 2020 at 03:54:37PM +0200, Thomas Bogendoerfer wrote: > On A20R machines the interrupt pending bits in cause register need to be > updated by requesting the chipset to do it. This needs to be done to > find the interrupt cause and after interrupt service. In > commit 0b888c7f3a03 ("MIPS: SNI: Convert to new irq_chip functions") the > function to do after service update got lost, which caused spurious > interrupts. > > Fixes: 0b888c7f3a03 ("MIPS: SNI: Convert to new irq_chip functions") > Signed-off-by: Thomas Bogendoerfer > --- > arch/mips/sni/a20r.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) applied to mips-fixes. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]