From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66DD1C43463 for ; Thu, 17 Sep 2020 20:35:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 05FAF206A4 for ; Thu, 17 Sep 2020 20:35:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=sent.com header.i=@sent.com header.b="fcyv2HJL"; dkim=temperror (0-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="CzR8aukL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726475AbgIQUfw (ORCPT ); Thu, 17 Sep 2020 16:35:52 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:52557 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726192AbgIQUfw (ORCPT ); Thu, 17 Sep 2020 16:35:52 -0400 X-Greylist: delayed 472 seconds by postgrey-1.27 at vger.kernel.org; Thu, 17 Sep 2020 16:35:51 EDT Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 06AF95C01B6; Thu, 17 Sep 2020 16:27:59 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 17 Sep 2020 16:27:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sent.com; h=from :to:cc:subject:date:message-id:reply-to:mime-version :content-transfer-encoding; s=fm1; bh=OgM+VF1MUscTM176XDGGZc3l3g r9Nz8gshk7U7FB/5c=; b=fcyv2HJLCiceEQXgNvAJS/jvaz6H2AFqYnzMSADXyB k0r8QYAbCvRhAVaFcZAq7NbLQTlNJwTMaJNZOictdMPi4uuUFT+O8QyGSx4ryjyc 6TdMGoxwYVk3opHKOHkBBtBVsf6mkcZbLDg+7pojFqjm+371rMWNKKOkEEpyBfEJ cHUzJl/GRhtdVxSyPdBHjI8eKUEUZtJ+IG/hcDkWg2XNBfEL0xi6U75PO5DtBsx/ Bp+/a0kUG1w/XjxDjS+IXeHwg5azTC+nrnZCjzaYu1Tz3LeIo8TzfMtZS2jLNkAj sQvWMPsorKSBbLBTwAtVQhwSkONW+KbUvlW4gRXDiCSw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:reply-to:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=OgM+VF 1MUscTM176XDGGZc3l3gr9Nz8gshk7U7FB/5c=; b=CzR8aukLuvb1RHmYqBsg7R Fgp0yw4zZ5OQdujDFdzTSGcwOFg9Lzt3EbV3NXsZvBxUPSZy2Yl1hZ8apSdpVeUE geIYvzrfV7gscwCO96PEfTRIQeCXl17q16Kd9rsy4hxSxSK6SFZQa+IDlQN1kVWv SsX/q7MbnHZS9vujaoynJ4GGHCTRudSK6QXNTYlRmE+8DzReymcc7EoyKY+LNWyq TRX+B+fv3EkpK5O3uzVcffr4K99YqaslMTkpA/nkDPt1xaHqIfO6z5vCi3EjLu7Z Mj4Yz/wysXnG/hK2b03FRBx3tvT4DyOVTvv/DGh6Ui0+06q8Or7CNjgW9rxw9ZZQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrtdeggdduheduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfforhgggfestdekredtredttdenucfhrhhomhepkghiucgjrghn uceoiihirdihrghnsehsvghnthdrtghomheqnecuggftrfgrthhtvghrnhepgfellefhvd eitdehffejheelgfehtdevheejhffgledtieehtdejffefveeijeehnecukfhppeduvddr geeirddutdeirdduieegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepiihirdihrghnsehsvghnthdrtghomh X-ME-Proxy: Received: from nvrsysarch6.NVidia.COM (unknown [12.46.106.164]) by mail.messagingengine.com (Postfix) with ESMTPA id E9CF53064683; Thu, 17 Sep 2020 16:27:57 -0400 (EDT) From: Zi Yan To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zi Yan , Daniel Jordan , Anshuman Khandual Subject: [PATCH] mm/migrate: correct thp migration stats. Date: Thu, 17 Sep 2020 16:27:29 -0400 Message-Id: <20200917202729.1460743-1-zi.yan@sent.com> X-Mailer: git-send-email 2.28.0 Reply-To: Zi Yan MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zi Yan PageTransHuge returns true for both thp and hugetlb, so thp stats was counting both thp and hugetlb migrations. Exclude hugetlb migration by setting is_thp variable right. Fixes: 1a5bae25e3cf ("mm/vmstat: add events for THP migration without split") Signed-off-by: Zi Yan Cc: Daniel Jordan Cc: Anshuman Khandual --- mm/migrate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/migrate.c b/mm/migrate.c index 941b89383cf3..d1ad964165e5 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -1445,7 +1445,7 @@ int migrate_pages(struct list_head *from, new_page_t get_new_page, * Capture required information that might get lost * during migration. */ - is_thp = PageTransHuge(page); + is_thp = PageTransHuge(page) && !PageHuge(page); nr_subpages = thp_nr_pages(page); cond_resched(); -- 2.28.0