From: David Miller <davem@davemloft.net>
To: hankinsea@gmail.com
Cc: richardcochran@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ptp: mark symbols static where possible
Date: Fri, 18 Sep 2020 14:15:56 -0700 (PDT) [thread overview]
Message-ID: <20200918.141556.1367737647918813478.davem@davemloft.net> (raw)
In-Reply-To: <20200918061013.2034-1-hankinsea@gmail.com>
From: Herrington <hankinsea@gmail.com>
Date: Fri, 18 Sep 2020 14:10:13 +0800
> +void pch_ch_control_write(struct pci_dev *pdev, u32 val);
> void pch_ch_control_write(struct pci_dev *pdev, u32 val)
Prototypes belong in a header file not in the C file where they
are defined.
If these functions are accessed in other foo.c files, they are
getting the prototype from some header file.
Otherwise they aren't, and the functions should be marked
static.
prev parent reply other threads:[~2020-09-18 21:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 6:10 Herrington
2020-09-18 15:51 ` Jakub Kicinski
2020-09-18 21:15 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200918.141556.1367737647918813478.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hankinsea@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®