From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46FDCC43463 for ; Fri, 18 Sep 2020 02:28:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1085323600 for ; Fri, 18 Sep 2020 02:28:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600396083; bh=1QMLin64MVWTNPN6qqj3EmmEWt0wEi4HzuuQKU7Nb3E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=CXF1ji6GMiwgxdMyHAwGYeznpuBGZzVIZWv7DgFMR6zCSOrrylzbU1xAU7xDFa7QZ poS6oU3zXV2nCNOkBb5SYDOCpp1h1KhJLaz9FCbrhGgQgePBu/nXVV6rx9hAzR2ZeO ayvyUxUw+utBuShBe9g8hJxNVizK4VNXcUXl1dV0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729237AbgIRCP3 (ORCPT ); Thu, 17 Sep 2020 22:15:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:44022 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729213AbgIRCPS (ORCPT ); Thu, 17 Sep 2020 22:15:18 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5369A23977; Fri, 18 Sep 2020 02:15:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600395318; bh=1QMLin64MVWTNPN6qqj3EmmEWt0wEi4HzuuQKU7Nb3E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KonTSGVf9FN98A++ZIaLfndJcxZ76kdznROTc77m87nd51D8IG/liUm0iq5slFIaH Lesy1b65DbKt8kOTgNTt42x0Y+5dG5+Z8OTnOW9pJ5rZlG1hUKrT0hH9g+vCZyLNiC KJUvEMgsJ3p8R1ESTL1LlcJdMRY8ktlG35RFzN9Y= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Vasily Averin , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 19/90] rt_cpu_seq_next should increase position index Date: Thu, 17 Sep 2020 22:13:44 -0400 Message-Id: <20200918021455.2067301-19-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200918021455.2067301-1-sashal@kernel.org> References: <20200918021455.2067301-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vasily Averin [ Upstream commit a3ea86739f1bc7e121d921842f0f4a8ab1af94d9 ] if seq_file .next fuction does not change position index, read after some lseek can generate unexpected output. https://bugzilla.kernel.org/show_bug.cgi?id=206283 Signed-off-by: Vasily Averin Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/ipv4/route.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index c8c51bd2d695b..e9aae4686536a 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -271,6 +271,7 @@ static void *rt_cpu_seq_next(struct seq_file *seq, void *v, loff_t *pos) *pos = cpu+1; return &per_cpu(rt_cache_stat, cpu); } + (*pos)++; return NULL; } -- 2.25.1