From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33B59C43463 for ; Fri, 18 Sep 2020 03:02:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E45CA206B7 for ; Fri, 18 Sep 2020 03:02:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="CDRIysij" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728985AbgIRDCS (ORCPT ); Thu, 17 Sep 2020 23:02:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730470AbgIRDBA (ORCPT ); Thu, 17 Sep 2020 23:01:00 -0400 Received: from mail-qk1-x749.google.com (mail-qk1-x749.google.com [IPv6:2607:f8b0:4864:20::749]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCF9EC061756 for ; Thu, 17 Sep 2020 20:00:59 -0700 (PDT) Received: by mail-qk1-x749.google.com with SMTP id w126so3444993qka.5 for ; Thu, 17 Sep 2020 20:00:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:message-id:mime-version:subject:from:to:cc; bh=MShH3I1oLcjvEJbj3NYW9C342mvg+PbbBJCOoSH1HSQ=; b=CDRIysijqlvkYU+kfz4ExesE+3SJEmw3l9qWCAyu0Yl6J6QfFZHDzRMn2cts4G/GOz due2AZm8uZnE02XEz5UeXJrQLnFVWnnCS9C/pPkMQNrCt04NXlx25xEYkfo0PmopvTxC 6Mc1ISZvlBE8hm/TYls84q50iEmrO8OTSwUfAOYHWxvmq5G4q3tHrvddW6BfGlAJaXXa 7jtZbfY4KCbYKA922DT7v4HaAYQlRavyHrrpgTJ650wUBUgxocGjlFGX5ZdwB2iFOxvt Sb0vnDNEX8KpkSdUPfi9dXotay6ssMYaQk9GrMx5bqH0g6TjEErAVqtu1pf7rtwPgd1d LRRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:message-id:mime-version:subject:from :to:cc; bh=MShH3I1oLcjvEJbj3NYW9C342mvg+PbbBJCOoSH1HSQ=; b=ecNemADDemBNepCqCxucWM3kMguMuwUNwIA1rdCX8sazdfXk62AHr7Ni4FEtbqZYlN kuyxvOH0Mba/nvUEwM/h/Thpj/+PEmIhdDLZh3+VCPFWVH3sr2hrDJV5hdfm2y4NJXeC /hRZu/QLtDs9UXDtAJPqGKm4Otpimjpeg2TuWGBLYDS5GgZr9ItJGHiC4t8IrVpFI0hw nIwtmpQ9OWZRd9a7y4QzImN5gUoifP4RvX1APKCLOPnpvWhCKCN0hHUBvQxWRjloZsxM 6ICewEiqQiAL/dM3cEMISQa1ebjXz5FYY1B4mJEAG6Lp/BKSH8jizGLoa6LKfv05rjaJ mR8Q== X-Gm-Message-State: AOAM533JMi5ZzKOFtve3vsr0y1S+5G61AWsTi71JRpg6Zl/F4rkj96im gXa8EMucNI8ZaGtjKQN9r/1LcIslC18= X-Google-Smtp-Source: ABdhPJx5px4YCOzuxVaL63VwwQLE+zcsL6qsTZcmWHgsANcGMolFMRqq/fwgx6MIzZ049mi7yH0PVbKuSkw= X-Received: from yuzhao.bld.corp.google.com ([2620:15c:183:200:7220:84ff:fe09:2d90]) (user=yuzhao job=sendgmr) by 2002:a0c:b21b:: with SMTP id x27mr31580996qvd.12.1600398058666; Thu, 17 Sep 2020 20:00:58 -0700 (PDT) Date: Thu, 17 Sep 2020 21:00:38 -0600 Message-Id: <20200918030051.650890-1-yuzhao@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.28.0.681.g6f77f65b4e-goog Subject: [PATCH 00/13] mm: clean up some lru related pieces From: Yu Zhao To: Andrew Morton , Michal Hocko Cc: Alex Shi , Steven Rostedt , Ingo Molnar , Johannes Weiner , Vladimir Davydov , Roman Gushchin , Shakeel Butt , Chris Down , Yafang Shao , Vlastimil Babka , Huang Ying , Pankaj Gupta , Matthew Wilcox , Konstantin Khlebnikov , Minchan Kim , Jaewon Kim , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yu Zhao Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrew, I see you have taken this: mm: use add_page_to_lru_list()/page_lru()/page_off_lru() Do you mind dropping it? Michal asked to do a bit of additional work. So I thought I probably should create a series to do more cleanups I've been meaning to. This series contains the change in the patch above and goes a few more steps farther. It's intended to improve readability and should not have any performance impacts. There are minor behavior changes in terms of debugging and error reporting, which I have all highlighted in the individual patches. All patches were properly tested on 5.8 running Chrome OS, with various debug options turned on. Michal, Do you mind taking a looking at the entire series? Thank you. Yu Zhao (13): mm: use add_page_to_lru_list() mm: use page_off_lru() mm: move __ClearPageLRU() into page_off_lru() mm: shuffle lru list addition and deletion functions mm: don't pass enum lru_list to lru list addition functions mm: don't pass enum lru_list to trace_mm_lru_insertion() mm: don't pass enum lru_list to del_page_from_lru_list() mm: rename page_off_lru() to __clear_page_lru_flags() mm: inline page_lru_base_type() mm: VM_BUG_ON lru page flags mm: inline __update_lru_size() mm: make lruvec_lru_size() static mm: enlarge the int parameter of update_lru_size() include/linux/memcontrol.h | 14 ++-- include/linux/mm_inline.h | 115 ++++++++++++++------------------- include/linux/mmzone.h | 2 - include/linux/vmstat.h | 2 +- include/trace/events/pagemap.h | 11 ++-- mm/compaction.c | 2 +- mm/memcontrol.c | 10 +-- mm/mlock.c | 2 +- mm/swap.c | 53 ++++++--------- mm/vmscan.c | 28 +++----- 10 files changed, 95 insertions(+), 144 deletions(-) -- 2.28.0.681.g6f77f65b4e-goog