mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Meng Yu <yumeng18@huawei.com>
Cc: davem@davemloft.net, linux-crypto@vger.kernel.org,
	xuzaibo@huawei.com, wangzhou1@hisilicon.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] crypto: hisilicon/hpre - fix a bug in dh algorithm
Date: Fri, 18 Sep 2020 17:11:12 +1000	[thread overview]
Message-ID: <20200918071112.GA9883@gondor.apana.org.au> (raw)
In-Reply-To: <1599737122-20734-4-git-send-email-yumeng18@huawei.com>

On Thu, Sep 10, 2020 at 07:25:22PM +0800, Meng Yu wrote:
>
> diff --git a/drivers/crypto/hisilicon/hpre/hpre_crypto.c b/drivers/crypto/hisilicon/hpre/hpre_crypto.c
> index 0cbe99a1..2d91593 100644
> --- a/drivers/crypto/hisilicon/hpre/hpre_crypto.c
> +++ b/drivers/crypto/hisilicon/hpre/hpre_crypto.c
> @@ -528,6 +528,8 @@ static int hpre_dh_compute_value(struct kpp_request *req)
>  		ret = hpre_hw_data_init(hpre_req, req->src, req->src_len, 1, 1);
>  		if (unlikely(ret))
>  			goto clear_all;
> +	} else {
> +		msg->in = cpu_to_le64((u64)ctx->dh.dma_g);

Why do you need the u64 cast?

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2020-09-18  7:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10 11:25 [PATCH 0/3] crypto: hisilicon/hpre - misc clean up and fixes Meng Yu
2020-09-10 11:25 ` [PATCH 1/3] crypto: hisilicon/hpre - delete an useless member Meng Yu
2020-09-10 11:25 ` [PATCH 2/3] crypto: hisilicon/hpre - adjust some coding style Meng Yu
2020-09-10 11:25 ` [PATCH 3/3] crypto: hisilicon/hpre - fix a bug in dh algorithm Meng Yu
2020-09-18  7:11   ` Herbert Xu [this message]
2020-09-18  8:44     ` yumeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200918071112.GA9883@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=davem@davemloft.net \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wangzhou1@hisilicon.com \
    --cc=xuzaibo@huawei.com \
    --cc=yumeng18@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®