From: Greg KH <gregkh@linuxfoundation.org>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] tty: serial: imx: fix link error with CONFIG_SERIAL_CORE_CONSOLE=n
Date: Fri, 18 Sep 2020 13:16:58 +0200 [thread overview]
Message-ID: <20200918111658.GB2242974@kroah.com> (raw)
In-Reply-To: <20200918091305.3822598-1-yangyingliang@huawei.com>
On Fri, Sep 18, 2020 at 05:13:05PM +0800, Yang Yingliang wrote:
> Fix the link error by selecting SERIAL_CORE_CONSOLE.
>
> aarch64-linux-gnu-ld: drivers/tty/serial/imx_earlycon.o: in function `imx_uart_console_early_write':
> imx_earlycon.c:(.text+0x84): undefined reference to `uart_console_write'
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/tty/serial/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index 9631ccf43378..1044fc387691 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -521,6 +521,7 @@ config SERIAL_IMX_EARLYCON
> depends on ARCH_MXC || COMPILE_TEST
> depends on OF
> select SERIAL_EARLYCON
> + select SERIAL_CORE_CONSOLE
> help
> If you have enabled the earlycon on the Freescale IMX
> CPU you can make it the earlycon by answering Y to this option.
> --
> 2.25.1
>
What caused this build error to start happening? Any pointers to the
specific commit?
thanks,
greg k-h
next prev parent reply other threads:[~2020-09-18 11:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 9:13 Yang Yingliang
2020-09-18 11:16 ` Greg KH [this message]
2020-09-19 2:26 ` Yang Yingliang
2020-09-19 5:41 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200918111658.GB2242974@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®