From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0418DC43464 for ; Sat, 19 Sep 2020 05:40:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A77DB20DD4 for ; Sat, 19 Sep 2020 05:40:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600494044; bh=4UDoglSsx5ePkj52lwygs8/ySTjMr9uDLxGKxasviws=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=0h9Taq5J2A1sAbrBGxZLUhLj9eUMsqhQItN2MsuY8HywOa2tPwRxJabFXmUS+JmJg Cdcyl3xcX1KKnZmTFtlmC+6/PsgjtNDAzcbLad+V6dsfVnY/Dd2ID4WTzhZyVZ4nk3 lk0R4xtKNZ9TuWt2mFpp2amCsGZ+fJGVRff80c6w= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726281AbgISFkn (ORCPT ); Sat, 19 Sep 2020 01:40:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:43588 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726129AbgISFkn (ORCPT ); Sat, 19 Sep 2020 01:40:43 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 132242074B; Sat, 19 Sep 2020 05:40:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600494042; bh=4UDoglSsx5ePkj52lwygs8/ySTjMr9uDLxGKxasviws=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IqvlWxn9E9n7ybWkey4E5EluYvuIOpNMeG8V3KlpTLmp4rymfIlGa4IUPhndVafl8 xezXIGWw8sx8z16tVYSXNctmRExipyQUsIJKffX4cqutoGKteYU2CdBPs9DMfSO7Y+ 5zBs+JlxQ4r9OkJRflI7o5A+KK2YWUWzMoNPQmGg= Date: Sat, 19 Sep 2020 07:40:38 +0200 From: Greg KH To: Yang Yingliang Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] tty: hvc: fix link error with CONFIG_SERIAL_CORE_CONSOLE=n Message-ID: <20200919054038.GA432686@kroah.com> References: <20200918092030.3855438-1-yangyingliang@huawei.com> <20200918111708.GC2242974@kroah.com> <6100a6e7-641f-7e9b-b4a3-3834320d1bb1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6100a6e7-641f-7e9b-b4a3-3834320d1bb1@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 19, 2020 at 10:48:41AM +0800, Yang Yingliang wrote: > > On 2020/9/18 19:17, Greg KH wrote: > > On Fri, Sep 18, 2020 at 05:20:30PM +0800, Yang Yingliang wrote: > > > Fix the link error by selecting SERIAL_CORE_CONSOLE. > > > > > > aarch64-linux-gnu-ld: drivers/tty/hvc/hvc_dcc.o: in function `dcc_early_write': > > > hvc_dcc.c:(.text+0x164): undefined reference to `uart_console_write' > > > > > > Reported-by: Hulk Robot > > > Signed-off-by: Yang Yingliang > > > --- > > > drivers/tty/hvc/Kconfig | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/tty/hvc/Kconfig b/drivers/tty/hvc/Kconfig > > > index d1b27b0522a3..8d60e0ff67b4 100644 > > > --- a/drivers/tty/hvc/Kconfig > > > +++ b/drivers/tty/hvc/Kconfig > > > @@ -81,6 +81,7 @@ config HVC_DCC > > > bool "ARM JTAG DCC console" > > > depends on ARM || ARM64 > > > select HVC_DRIVER > > > + select SERIAL_CORE_CONSOLE > > > help > > > This console uses the JTAG DCC on ARM to create a console under the HVC > > > driver. This console is used through a JTAG only on ARM. If you don't have > > > -- > > > 2.25.1 > > > > > Same question here, what caused this problem to happen? > Fixes: d1a1af2cdf19 ("hvc: dcc: Add earlycon support") Great, can you resend with that added please? thanks, greg k-h