From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3622FC43463 for ; Sat, 19 Sep 2020 19:22:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA69021707 for ; Sat, 19 Sep 2020 19:22:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="Tx7WEG+h" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726664AbgISTWi (ORCPT ); Sat, 19 Sep 2020 15:22:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726518AbgISTWi (ORCPT ); Sat, 19 Sep 2020 15:22:38 -0400 Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com [IPv6:2607:f8b0:4864:20::741]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE911C0613CE for ; Sat, 19 Sep 2020 12:22:37 -0700 (PDT) Received: by mail-qk1-x741.google.com with SMTP id v123so10502046qkd.9 for ; Sat, 19 Sep 2020 12:22:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=IfjJMShMAYEFKN5YLXC6yZVzsTKuAmJMrDmWZpivwoY=; b=Tx7WEG+h7F8CDjBu/jlOiysl3JQczwwLMYKLACitzc0UuMfh/mFPRT69zR9TY7H7Y8 nRAsWx6u92MdLzYVKoSx5YIx4mt2rFOhQDzMPgq8dyo85LutFSqYJPxlyMr370qVWQPh H9FeOWLwKF4zY4yKCuV+VGlC11W6EsuvkqvRVvXLEIkJO+TPJe+zoiNQjaGzFOpY/2Pv 0N2qI5aTyiz4H09KoLRv5WBBGvKV0pGaUI32g5Xey8ZEe9I9PREMEmdZyHtniJQlMHhM vMq3MaatsAiEqhudJATetXS0Osaw8bIme03wLXpLmlJHKa+tt0fWG+C8mmjNMTlYaN/O IogA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IfjJMShMAYEFKN5YLXC6yZVzsTKuAmJMrDmWZpivwoY=; b=ZSevLdq3T9ZGVlno8EkQGAQ8sSBoV361YduSFD/e0NziHE7kK0HyxvDg6G2Bib4nYL Z7gCoVWfQMo1o7G1qAGCOlmeHFxf0rNs19jQIh5ie1IWJrIg7FxnyOYvwk9bSjV3sEp1 b5Mg4gRrwb1ZIKnAQYz/cOOf5vruQKZSfjWtC5p4dOMQfrrhpTVQbxelQbQiyuRWmMGw wMwy7UTLbK/GIhtsXIgxihikbVCi/7IeTR0ZCJv8oUFBabYby0eLDmie5E3Q7HGHEBi0 DeKPSe7hTqFVnjlw3ue9bVTMm1JwD/ve9Kyenh3i8dkI8M724gvftaJ5nHZQdE5a7fD+ vfdg== X-Gm-Message-State: AOAM531cz3sf7bKfvFC/8U9vwB4tGFO9b9QMw7FS3hFsiM/AyVRVAcBV j9TMEsz+1E9ZMh0q/Ad6hrQGMQ== X-Google-Smtp-Source: ABdhPJxk5odPvPQ8xzh4HdByt+rV02OFXI2X/xCfsTAiUmLUSkpZ3MTa9p4Iad69Vfo49XEZDj73Cw== X-Received: by 2002:a37:9bd8:: with SMTP id d207mr41437784qke.100.1600543356975; Sat, 19 Sep 2020 12:22:36 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id b43sm5299375qtk.84.2020.09.19.12.22.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Sep 2020 12:22:36 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kJiRP-0027Dz-Nf; Sat, 19 Sep 2020 16:22:35 -0300 Date: Sat, 19 Sep 2020 16:22:35 -0300 From: Jason Gunthorpe To: Greg Kroah-Hartman Cc: Oded Gabbay , Leon Romanovsky , Gal Pressman , Jakub Kicinski , "Linux-Kernel@Vger. Kernel. Org" , netdev@vger.kernel.org, SW_Drivers , "David S. Miller" , Andrew Lunn , Florian Fainelli , linux-rdma@vger.kernel.org Subject: Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver Message-ID: <20200919192235.GB8409@ziepe.ca> References: <20200918115227.GR869610@unreal> <20200918120340.GT869610@unreal> <20200918121905.GU869610@unreal> <20200919064020.GC439518@kroah.com> <20200919082003.GW869610@unreal> <20200919083012.GA465680@kroah.com> <20200919172730.GC2733595@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200919172730.GC2733595@kroah.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 19, 2020 at 07:27:30PM +0200, Greg Kroah-Hartman wrote: > > It's probably heresy, but why do I need to integrate into the RDMA subsystem ? > > I understand your reasoning about networking (Ethernet) as the driver > > connects to the kernel networking stack (netdev), but with RDMA the > > driver doesn't use or connect to anything in that stack. If I were to > > support IBverbs and declare that I support it, then of course I would > > need to integrate to the RDMA subsystem and add my backend to > > rdma-core. > > IBverbs are horrid and I would not wish them on anyone. Seriously. I'm curious what drives this opinion? Did you have it since you reviewed the initial submission all those years ago? > I think the general rdma apis are the key here, not the userspace api. Are you proposing that habana should have uAPI in drivers/misc and present a standard rdma-core userspace for it? This is the only userspace programming interface for RoCE HW. I think that would be much more work. If not, what open source userspace are you going to ask them to present to merge the kernel side into misc? > Note, I do not know exactly what they are, but no, IBverbs are not ok. Should we stop merging new drivers and abandon the RDMA subsystem? Is there something you'd like to see fixed? Don't really understand your position, sorry. Jason