From: Andrew Lunn <andrew@lunn.ch>
To: Robert Marko <robert.marko@sartura.hr>
Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Luka Perkov <luka.perkov@sartura.hr>
Subject: Re: [PATCH v3 2/2] net: mdio-ipq4019: add Clause 45 support
Date: Sun, 20 Sep 2020 02:19:04 +0200 [thread overview]
Message-ID: <20200920001904.GB3673389@lunn.ch> (raw)
In-Reply-To: <20200918205633.2698654-3-robert.marko@sartura.hr>
> +
> +/* 0 = Clause 22, 1 = Clause 45 */
> +#define MDIO_MODE_BIT BIT(8)
How about calling this MDIO_MODE_C45
> + /* Enter Clause 45 mode */
> + data = readl(priv->membase + MDIO_MODE_REG);
> +
> + data |= MDIO_MODE_BIT;
> +
> + writel(data, priv->membase + MDIO_MODE_REG);
It then becomes clearer what this does.
Otherwise this looks O.K.
Andrew
next prev parent reply other threads:[~2020-09-20 0:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 20:56 [PATCH v3 0/2] " Robert Marko
2020-09-18 20:56 ` [PATCH v3 1/2] net: mdio-ipq4019: change defines to upper case Robert Marko
2020-09-18 20:56 ` [PATCH v3 2/2] net: mdio-ipq4019: add Clause 45 support Robert Marko
2020-09-20 0:19 ` Andrew Lunn [this message]
2020-09-20 14:18 ` Robert Marko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200920001904.GB3673389@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=luka.perkov@sartura.hr \
--cc=netdev@vger.kernel.org \
--cc=robert.marko@sartura.hr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®