From: "Paul E. McKenney" <paulmck@kernel.org>
To: Asif Rasheed <b00073877@aus.edu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging list.h: Modified comment
Date: Sun, 20 Sep 2020 08:18:22 -0700 [thread overview]
Message-ID: <20200920151822.GA29330@paulmck-ThinkPad-P72> (raw)
In-Reply-To: <20200920133154.71514-1-b00073877@aus.edu>
On Sun, Sep 20, 2020 at 05:31:54PM +0400, Asif Rasheed wrote:
> We (everyone from my Operating System Lecture Section) were confused on whether the list is circular or not (because no one bothered to look at the implementation). Modified the comment on top for clarification.
>
> Signed-off-by: Asif Rasheed <b00073877@aus.edu>
Good point! "Simple" here means "not complex", but given the size of
this file, one could argue that this characterization is long obsolete.
I queued your patch for v5.11, but as usual could not resist the
urge to edit the commit log. Could you please review the version
below to make sure that I did not mess anything up?
Thanx, Paul
------------------------------------------------------------------------
commit 8ac8c191b5f1a42b02462d5b35675f2439097b86
Author: Asif Rasheed <b00073877@aus.edu>
Date: Sun Sep 20 17:31:54 2020 +0400
list.h: Update comment to explicitly note circular lists
The students in the Operating System Lecture Section at the
American University of Sharjah were confused by the header comment
in include/linux/list.h, which says "Simple doubly linked list
implementation". This comment means "simple" as in "not complex",
but "simple" is often used in this context to mean "not circular".
This commit therefore avoids this ambiguity by explicitly calling out
"circular".
Signed-off-by: Asif Rasheed <b00073877@aus.edu>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
diff --git a/include/linux/list.h b/include/linux/list.h
index 0d0d17a..796975c 100644
--- a/include/linux/list.h
+++ b/include/linux/list.h
@@ -9,7 +9,7 @@
#include <linux/kernel.h>
/*
- * Simple doubly linked list implementation.
+ * Circular doubly linked list implementation.
*
* Some of the internal functions ("__xxx") are useful when
* manipulating whole lists rather than single entries, as
next prev parent reply other threads:[~2020-09-20 15:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-20 13:31 Asif Rasheed
2020-09-20 15:18 ` Paul E. McKenney [this message]
2020-09-20 17:00 ` Asif Rasheed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200920151822.GA29330@paulmck-ThinkPad-P72 \
--to=paulmck@kernel.org \
--cc=b00073877@aus.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®