mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Qinglang Miao <miaoqinglang@huawei.com>
Cc: Santosh Shilimkar <ssantosh@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next v2] memory: emif: Convert to DEFINE_SHOW_ATTRIBUTE
Date: Sun, 20 Sep 2020 18:59:33 +0200	[thread overview]
Message-ID: <20200920165933.GB16677@kozik-lap> (raw)
In-Reply-To: <20200917125113.103550-1-miaoqinglang@huawei.com>

On Thu, Sep 17, 2020 at 08:51:13PM +0800, Qinglang Miao wrote:
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
> 
> Along with this change, we get additionally:
>         .owner          = THIS_MODULE,
>         .llseek         = seq_lseek,
> 
> 1. The llseek method is used to change the current read/write position
> in a file which can be ignored if you don't use it.
> 2. The owner is not even a method. Instead, it is a pointer to the
> module that “owns” this structure; it is used by the kernel to maintain
> the module's usage count which can be ignored.
> 
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
> ---
> v2: based on linux-next(20200917), and can be applied to
>     mainline cleanly now.
> 
>  drivers/memory/emif.c | 22 ++--------------------

Thanks, applied.

Best regards,
Krzysztof


      reply	other threads:[~2020-09-20 16:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-17 12:51 Qinglang Miao
2020-09-20 16:59 ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200920165933.GB16677@kozik-lap \
    --to=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miaoqinglang@huawei.com \
    --cc=ssantosh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®