From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Julien Thierry <jthierry@redhat.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, mbenes@suse.cz
Subject: Re: [PATCH 3/3] objtool: check: Handle calling non-function symbols in other sections
Date: Mon, 21 Sep 2020 09:40:08 -0500 [thread overview]
Message-ID: <20200921144008.n6c37mgby772bs5i@treble> (raw)
In-Reply-To: <5afa4c67-f557-b1c4-d94c-da7610f4fcbe@redhat.com>
On Mon, Sep 21, 2020 at 10:56:05AM +0100, Julien Thierry wrote:
>
>
> On 9/18/20 9:07 PM, Josh Poimboeuf wrote:
> > On Tue, Sep 15, 2020 at 08:53:18AM +0100, Julien Thierry wrote:
> > > Relocation for a call destination could point to a symbol that has
> > > type STT_NOTYPE.
> >
> > Then shouldn't the callee be changed to STT_FUNC?
> >
>
> Not if it's a code symbol that does not follow standard calling convention.
>
> It's really the same case as the !reloc, except this time it's in a
> different .text section.
Yeah, that makes sense. I'll take this one as well.
--
Josh
next prev parent reply other threads:[~2020-09-21 14:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 7:53 [PATCH 0/3] objtool: Miscellaneous cleanup/fixes Julien Thierry
2020-09-15 7:53 ` [PATCH 1/3] objtool: check: Remove useless tests Julien Thierry
2020-09-15 7:53 ` [PATCH 2/3] objtool: check: Ignore unreachable fake jumps Julien Thierry
2020-09-15 7:53 ` [PATCH 3/3] objtool: check: Handle calling non-function symbols in other sections Julien Thierry
2020-09-18 20:07 ` Josh Poimboeuf
2020-09-21 9:56 ` Julien Thierry
2020-09-21 14:40 ` Josh Poimboeuf [this message]
2020-09-18 21:47 ` [PATCH 0/3] objtool: Miscellaneous cleanup/fixes Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200921144008.n6c37mgby772bs5i@treble \
--to=jpoimboe@redhat.com \
--cc=jthierry@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®