From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 303E8C4347E for ; Mon, 21 Sep 2020 17:43:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E72712086A for ; Mon, 21 Sep 2020 17:43:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600710202; bh=cKsg3hVBq8JmOrVbzOqJFlMVUVoBqKhQpJuOU8riZ5w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=iDsygZNpUpJAonO2naBEC7FYp9c/on+vZO2IxxL/No8z6+2ml5WvZNcNz3EIDX2Y1 Z8RpqPKQb1qcxrZC+qA55P5GI1J6aLs81pYURN4J5qom0FjssH5Z6SMT1qbvkO0Spz UYsVLU8+nO6SPqu0ERNdFBRVnATagmcWIwqtqq/c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728107AbgIURnU (ORCPT ); Mon, 21 Sep 2020 13:43:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:50462 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727248AbgIURnU (ORCPT ); Mon, 21 Sep 2020 13:43:20 -0400 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3932C20BED; Mon, 21 Sep 2020 17:43:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600710200; bh=cKsg3hVBq8JmOrVbzOqJFlMVUVoBqKhQpJuOU8riZ5w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bZyYgvBmKfZafOxEhG2K4ORoS3NEEMdspfjYl1vEVg3HOT6ZU9h9MfGFZSDDW6Woi gAJqaHEVxKi6HKTncc3Vct29nwp2hQYwT44hPDj2RpazfmZ3W4XyakP/Nh/plx2jvJ LTo1ntQ9HIOiZEeW5jyZgK/OaeoGYlyNg2F6E9mE= Date: Mon, 21 Sep 2020 18:43:15 +0100 From: Will Deacon To: sudaraja@codeaurora.org Cc: Anshuman Khandual , Steven Price , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Catalin Marinas , Mark Rutland , Logan Gunthorpe , David Hildenbrand , Andrew Morton , pratikp@codeaurora.org Subject: Re: [PATCH] arm64/mm: add fallback option to allocate virtually contiguous memory Message-ID: <20200921174313.GA3141@willie-the-truck> References: <01010174769e2b68-a6f3768e-aef8-43c7-b357-a8cb1e17d3eb-000000@us-west-2.amazonses.com> <145c57a3-1753-3ff8-4353-3bf7bac0b7de@arm.com> <0101017479c7063b-aec9b77c-4f0f-41b6-84e6-f91a5ed1f3f6-000000@us-west-2.amazonses.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0101017479c7063b-aec9b77c-4f0f-41b6-84e6-f91a5ed1f3f6-000000@us-west-2.amazonses.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 10, 2020 at 08:48:40PM +0000, sudaraja@codeaurora.org wrote: > On 2020-09-10 03:50, Anshuman Khandual wrote: > > The proposed patch tried to mix both approaches. Regardless, the first > > approach > > here seems better and is the case in vmemmap_populate_hugepages() > > implementation > > on x86 as well. > > The 1st approach looks more cleaner compared to bailing out in first > failure, unmapping all previously mapped sections and map entire request > with vmemmap_populate_basepages. Thanks for the review and suggestion - will > send over a cleaner patch soon. Did you send an updated version of this? The threading has gone wonky in my mail client, so I may have missed it. Will