From: Kent Gibson <warthog618@gmail.com>
To: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
bgolaszewski@baylibre.com, linus.walleij@linaro.org,
andy.shevchenko@gmail.com
Cc: arnd@arndb.de, Kent Gibson <warthog618@gmail.com>
Subject: [PATCH v9 11/20] gpiolib: cdev: support GPIO_V2_LINE_SET_VALUES_IOCTL
Date: Tue, 22 Sep 2020 10:31:42 +0800 [thread overview]
Message-ID: <20200922023151.387447-12-warthog618@gmail.com> (raw)
In-Reply-To: <20200922023151.387447-1-warthog618@gmail.com>
Add support for the GPIO_V2_LINE_SET_VALUES_IOCTL.
Signed-off-by: Kent Gibson <warthog618@gmail.com>
---
drivers/gpio/gpiolib-cdev.c | 61 +++++++++++++++++++++++++++++++++++++
1 file changed, 61 insertions(+)
diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c
index debd3b277523..ba951f74e569 100644
--- a/drivers/gpio/gpiolib-cdev.c
+++ b/drivers/gpio/gpiolib-cdev.c
@@ -813,6 +813,65 @@ static long linereq_get_values(struct linereq *lr, void __user *ip)
return 0;
}
+static long linereq_set_values_unlocked(struct linereq *lr,
+ struct gpio_v2_line_values *lv)
+{
+ DECLARE_BITMAP(vals, GPIO_V2_LINES_MAX);
+ struct gpio_desc **descs;
+ unsigned int i, didx, num_set;
+ int ret;
+
+ bitmap_zero(vals, GPIO_V2_LINES_MAX);
+ for (num_set = 0, i = 0; i < lr->num_lines; i++) {
+ if (lv->mask & BIT_ULL(i)) {
+ if (!test_bit(FLAG_IS_OUT, &lr->lines[i].desc->flags))
+ return -EPERM;
+ if (lv->bits & BIT_ULL(i))
+ __set_bit(num_set, vals);
+ num_set++;
+ descs = &lr->lines[i].desc;
+ }
+ }
+ if (num_set == 0)
+ return -EINVAL;
+
+ if (num_set != 1) {
+ /* build compacted desc array and values */
+ descs = kmalloc_array(num_set, sizeof(*descs), GFP_KERNEL);
+ if (!descs)
+ return -ENOMEM;
+ for (didx = 0, i = 0; i < lr->num_lines; i++) {
+ if (lv->mask & BIT_ULL(i)) {
+ descs[didx] = lr->lines[i].desc;
+ didx++;
+ }
+ }
+ }
+ ret = gpiod_set_array_value_complex(false, true, num_set,
+ descs, NULL, vals);
+
+ if (num_set != 1)
+ kfree(descs);
+ return ret;
+}
+
+static long linereq_set_values(struct linereq *lr, void __user *ip)
+{
+ struct gpio_v2_line_values lv;
+ int ret;
+
+ if (copy_from_user(&lv, ip, sizeof(lv)))
+ return -EFAULT;
+
+ mutex_lock(&lr->config_mutex);
+
+ ret = linereq_set_values_unlocked(lr, &lv);
+
+ mutex_unlock(&lr->config_mutex);
+
+ return ret;
+}
+
static long linereq_set_config_unlocked(struct linereq *lr,
struct gpio_v2_line_config *lc)
{
@@ -889,6 +948,8 @@ static long linereq_ioctl(struct file *file, unsigned int cmd,
if (cmd == GPIO_V2_LINE_GET_VALUES_IOCTL)
return linereq_get_values(lr, ip);
+ else if (cmd == GPIO_V2_LINE_SET_VALUES_IOCTL)
+ return linereq_set_values(lr, ip);
else if (cmd == GPIO_V2_LINE_SET_CONFIG_IOCTL)
return linereq_set_config(lr, ip);
--
2.28.0
next prev parent reply other threads:[~2020-09-22 2:36 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 2:31 [PATCH v9 00/20] gpio: cdev: add uAPI v2 Kent Gibson
2020-09-22 2:31 ` [PATCH v9 01/20] gpiolib: cdev: gpio_desc_to_lineinfo() should set info offset Kent Gibson
2020-09-22 2:31 ` [PATCH v9 02/20] gpiolib: cdev: replace strncpy() with strscpy() Kent Gibson
2020-09-22 2:31 ` [PATCH v9 03/20] gpio: uapi: define GPIO_MAX_NAME_SIZE for array sizes Kent Gibson
2020-09-22 2:31 ` [PATCH v9 04/20] gpio: uapi: define uAPI v2 Kent Gibson
2020-09-22 7:41 ` Arnd Bergmann
2020-09-22 9:50 ` Bartosz Golaszewski
2020-09-22 10:07 ` Kent Gibson
2020-09-23 10:04 ` Andy Shevchenko
2020-09-23 10:30 ` Kent Gibson
2020-09-23 11:16 ` Andy Shevchenko
2020-09-23 12:18 ` Arnd Bergmann
2020-09-23 15:15 ` Andy Shevchenko
2020-09-22 2:31 ` [PATCH v9 05/20] gpiolib: make cdev a build option Kent Gibson
2020-09-22 2:31 ` [PATCH v9 06/20] gpiolib: add build option for CDEV v1 ABI Kent Gibson
2020-09-22 2:31 ` [PATCH v9 07/20] gpiolib: cdev: support GPIO_V2_GET_LINE_IOCTL and GPIO_V2_LINE_GET_VALUES_IOCTL Kent Gibson
2020-09-23 11:11 ` Andy Shevchenko
2020-09-24 8:09 ` Kent Gibson
2020-09-25 10:06 ` Andy Shevchenko
2020-09-26 9:16 ` Kent Gibson
2020-09-27 9:00 ` Andy Shevchenko
2020-09-27 12:39 ` Kent Gibson
2020-09-24 14:29 ` Bartosz Golaszewski
2020-09-22 2:31 ` [PATCH v9 08/20] gpiolib: cdev: support GPIO_V2_GET_LINEINFO_IOCTL and GPIO_V2_GET_LINEINFO_WATCH_IOCTL Kent Gibson
2020-09-23 15:41 ` Andy Shevchenko
2020-09-24 2:39 ` Kent Gibson
2020-09-24 8:39 ` Andy Shevchenko
2020-09-24 9:48 ` Kent Gibson
2020-09-25 10:12 ` Andy Shevchenko
2020-09-25 11:56 ` Kent Gibson
2020-09-25 14:43 ` Andy Shevchenko
2020-09-25 5:32 ` Kent Gibson
2020-09-22 2:31 ` [PATCH v9 09/20] gpiolib: cdev: support edge detection for uAPI v2 Kent Gibson
2020-09-23 15:47 ` Andy Shevchenko
2020-09-24 3:07 ` Kent Gibson
2020-09-25 9:35 ` Andy Shevchenko
2020-09-25 12:26 ` Kent Gibson
2020-09-25 14:48 ` Andy Shevchenko
2020-09-22 2:31 ` [PATCH v9 10/20] gpiolib: cdev: support GPIO_V2_LINE_SET_CONFIG_IOCTL Kent Gibson
2020-09-23 16:14 ` Andy Shevchenko
2020-09-23 16:15 ` Andy Shevchenko
2020-09-24 3:24 ` Kent Gibson
2020-09-24 8:26 ` Andy Shevchenko
2020-09-24 9:26 ` Kent Gibson
2020-09-25 9:49 ` Andy Shevchenko
2020-09-22 2:31 ` Kent Gibson [this message]
2020-09-23 16:18 ` [PATCH v9 11/20] gpiolib: cdev: support GPIO_V2_LINE_SET_VALUES_IOCTL Andy Shevchenko
2020-09-24 7:32 ` Kent Gibson
2020-09-24 8:21 ` Andy Shevchenko
2020-09-24 9:08 ` Kent Gibson
2020-09-24 12:46 ` Kent Gibson
2020-09-25 9:57 ` Andy Shevchenko
2020-09-25 12:16 ` Kent Gibson
2020-09-22 2:31 ` [PATCH v9 12/20] gpiolib: cdev: support setting debounce Kent Gibson
2020-09-23 16:27 ` Andy Shevchenko
2020-09-24 7:48 ` Kent Gibson
2020-09-25 9:43 ` Andy Shevchenko
2020-09-22 2:31 ` [PATCH v9 13/20] gpio: uapi: document uAPI v1 as deprecated Kent Gibson
2020-09-22 7:49 ` Arnd Bergmann
2020-09-22 8:11 ` Andy Shevchenko
2020-09-22 9:05 ` Kent Gibson
2020-09-22 2:31 ` [PATCH v9 14/20] tools: gpio: port lsgpio to v2 uAPI Kent Gibson
2020-09-22 2:31 ` [PATCH v9 15/20] tools: gpio: port gpio-watch " Kent Gibson
2020-09-22 2:31 ` [PATCH v9 16/20] tools: gpio: rename nlines to num_lines Kent Gibson
2020-09-22 2:31 ` [PATCH v9 17/20] tools: gpio: port gpio-hammer to v2 uAPI Kent Gibson
2020-09-23 16:30 ` Andy Shevchenko
2020-09-24 7:50 ` Kent Gibson
2020-09-22 2:31 ` [PATCH v9 18/20] tools: gpio: port gpio-event-mon " Kent Gibson
2020-09-22 2:31 ` [PATCH v9 19/20] tools: gpio: add multi-line monitoring to gpio-event-mon Kent Gibson
2020-09-22 2:31 ` [PATCH v9 20/20] tools: gpio: add debounce support " Kent Gibson
2020-09-23 16:35 ` [PATCH v9 00/20] gpio: cdev: add uAPI v2 Andy Shevchenko
2020-09-24 8:00 ` Kent Gibson
2020-09-25 9:44 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200922023151.387447-12-warthog618@gmail.com \
--to=warthog618@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome