From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D128CC4363D for ; Tue, 22 Sep 2020 18:31:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 788882065D for ; Tue, 22 Sep 2020 18:31:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="aAJ+/aBc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726713AbgIVSb2 (ORCPT ); Tue, 22 Sep 2020 14:31:28 -0400 Received: from mx2.suse.de ([195.135.220.15]:48200 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726526AbgIVSb2 (ORCPT ); Tue, 22 Sep 2020 14:31:28 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1600799486; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6V2DffdTKL8UOfFVJCLTmEpEQRVobEw0bM3wzRvskX0=; b=aAJ+/aBcg20EvZdS+X29DSgXibh2SuIV4rOW6CMaDZ+Pit8vIFgMiebbhfGFBvuHU1MhE9 XQSfFShMcnDvylbwIJQzl7c27qOoZ/XLFVHf0Jxk6XBU8RUccqPBukgHgD+OWuaC4DQNZQ 5eYSTdekQh3y/lAM57xb6g9ELjrWCoM= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 52FCAAE64; Tue, 22 Sep 2020 18:32:03 +0000 (UTC) Date: Tue, 22 Sep 2020 20:31:25 +0200 From: Michal Hocko To: Shakeel Butt Cc: Minchan Kim , Johannes Weiner , Roman Gushchin , Greg Thelen , David Rientjes , Michal =?iso-8859-1?Q?Koutn=FD?= , Andrew Morton , Linux MM , Cgroups , LKML , Yang Shi Subject: Re: [PATCH] memcg: introduce per-memcg reclaim interface Message-ID: <20200922183125.GG12990@dhcp22.suse.cz> References: <20200909215752.1725525-1-shakeelb@google.com> <20200921163055.GQ12990@dhcp22.suse.cz> <20200922114908.GZ12990@dhcp22.suse.cz> <20200922165527.GD12990@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 22-09-20 11:10:17, Shakeel Butt wrote: > On Tue, Sep 22, 2020 at 9:55 AM Michal Hocko wrote: [...] > > So far I have learned that you are primarily working around an > > implementation detail in the zswap which is doing the swapout path > > directly in the pageout path. > > Wait how did you reach this conclusion? I have explicitly said that we > are not using uswapd like functionality in production. We are using > this interface for proactive reclaim and proactive reclaim is not a > workaround for implementation detail in the zswap. Hmm, I must have missed the distinction between the two you have mentioned. Correct me if I am wrong but "latency sensitive" workload is the one that cannot use the high limit, right. For some reason I thought that your pro-active reclaim usecase is also not compatible with the throttling imposed by the high limit. Hence my conclusion above. -- Michal Hocko SUSE Labs