From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0A84C4727D for ; Tue, 22 Sep 2020 20:05:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 57C34221E8 for ; Tue, 22 Sep 2020 20:05:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726762AbgIVUF0 (ORCPT ); Tue, 22 Sep 2020 16:05:26 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:54916 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726567AbgIVUF0 (ORCPT ); Tue, 22 Sep 2020 16:05:26 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 9238C1C0BAC; Tue, 22 Sep 2020 22:05:24 +0200 (CEST) Date: Tue, 22 Sep 2020 22:05:24 +0200 From: Pavel Machek To: Saeed Mahameed Cc: eranbe@mellanox.com, lariel@mellanox.com, saeedm@mellanox.com, leon@kernel.org, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net/mlx5: remove unreachable return Message-ID: <20200922200524.GA4975@duo.ucw.cz> References: <20200921114103.GA21071@duo.ucw.cz> <5d37fdcb0d50d79f93e8cdb31cb3f182548ffcc1.camel@kernel.org> <4eb581435bd7ac528c29815a7d26016bd1c429f4.camel@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jRHKVT23PllUwdXP" Content-Disposition: inline In-Reply-To: <4eb581435bd7ac528c29815a7d26016bd1c429f4.camel@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --jRHKVT23PllUwdXP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue 2020-09-22 12:54:20, Saeed Mahameed wrote: > On Mon, 2020-09-21 at 22:54 -0700, Saeed Mahameed wrote: > > On Mon, 2020-09-21 at 13:41 +0200, Pavel Machek wrote: > > > The last return statement is unreachable code. I'm not sure if it > > > will > > > provoke any warnings, but it looks ugly. > > > =20 > > > Signed-off-by: Pavel Machek (CIP) > > >=20 > > >=20 > >=20 > > Applied to net-next-mlx5. > >=20 > > Thanks, > > Saeed. > >=20 >=20 > Actually checkpatch reports this issue: > WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal > patch author 'Pavel Machek ' >=20 > Do you want me to override the Signed-off-by tag with the above email ? Sorry about that. Actually, overriding patch author to match signoff would be better (I should have sent it from: denx), but either way is okay with me. Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --jRHKVT23PllUwdXP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCX2pZBAAKCRAw5/Bqldv6 8jkJAKCN+rn7YSGCZRIAF9TT3/s9SQHGWQCfdyaR/Z42wf5Wjz13hY8Ctge+uIk= =sk8T -----END PGP SIGNATURE----- --jRHKVT23PllUwdXP--