From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Y4r4=DA=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,
	USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id B5CF3C2D0A8
	for <linux-kernel@archiver.kernel.org>; Wed, 23 Sep 2020 16:09:29 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 6D37C214F1
	for <linux-kernel@archiver.kernel.org>; Wed, 23 Sep 2020 16:09:29 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726855AbgIWQJ2 (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Wed, 23 Sep 2020 12:09:28 -0400
Received: from mail.kernel.org ([198.145.29.99]:39774 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726537AbgIWQJ2 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 23 Sep 2020 12:09:28 -0400
Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 92194206B5;
        Wed, 23 Sep 2020 16:09:26 +0000 (UTC)
Date:   Wed, 23 Sep 2020 12:09:24 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Yafang Shao <laoar.shao@gmail.com>
Cc:     Axel Rasmussen <axelrasmussen@google.com>,
        Ingo Molnar <mingo@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        Michel Lespinasse <walken@google.com>,
        Daniel Jordan <daniel.m.jordan@oracle.com>,
        Davidlohr Bueso <dbueso@suse.de>,
        LKML <linux-kernel@vger.kernel.org>,
        Linux MM <linux-mm@kvack.org>
Subject: Re: [PATCH] mmap_lock: add tracepoints around lock acquisition
Message-ID: <20200923120924.49638d90@oasis.local.home>
In-Reply-To: <CALOAHbD2qgvd7CHy6ZFJ_h8drtRWEU=E-hPofY-TuGTNfxyQbw@mail.gmail.com>
References: <20200917181347.1359365-1-axelrasmussen@google.com>
        <CALOAHbDSHGeXjJN3E5mTOAFTVsXAvQL9+nSYTqht5Lz8HRNv0A@mail.gmail.com>
        <CAJHvVcg6eY0vVtfi8D6D9aus7=5zeP2H7Yc0mY5ofXztSzOFqQ@mail.gmail.com>
        <CALOAHbBr=ASfvHw1ZscWBE=CY-e7sBrLV0F5Ow=g1UGxmQsWcw@mail.gmail.com>
        <20200922125113.12ef1e03@gandalf.local.home>
        <CALOAHbD2qgvd7CHy6ZFJ_h8drtRWEU=E-hPofY-TuGTNfxyQbw@mail.gmail.com>
X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 23 Sep 2020 18:04:17 +0800
Yafang Shao <laoar.shao@gmail.com> wrote:

> > What you can do, and what we have done is the following:
> >
> > (see include/linux/page_ref.h)
> >
> >
> > #ifdef CONFIG_TRACING
> > extern struct tracepoint __tracepoint_mmap_lock_start_locking;
> > extern struct tracepoint __tracepoint_mmap_lock_acquire_returned;
> >
> > #define mmap_lock_tracepoint_active(t) static_key_false(&(__tracepoint_mmap_lock_##t).key)
> >
> > #else
> > #define mmap_lock_tracepoint_active(t) false
> > #endif
> >
> > static inline void mmap_write_lock(struct mm_struct *mm)
> > {
> >         if (mmap_lock_tracepoint_active(start_locking))
> >                 mmap_lock_start_trace_wrapper();
> >         down_write(&mm->mmap_lock);
> >         if (mmap_lock_tracepoint_active(acquire_returned))
> >                 mmap_lock_acquire_trace_wrapper();
> > }
> >
> >
> > -- Steve  
> 
> 
> Great!
> 
> Thanks Steve.

If the above becomes useful, I may just add helper functions into a
header file that you can include. Perhaps call it: tracepoint_active()
and you need to pass in as an argument the name of the tracepoint.

-- Steve