From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE8EEC4346E for ; Fri, 25 Sep 2020 03:10:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 640F02083B for ; Fri, 25 Sep 2020 03:10:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601003436; bh=Ds+x7kGYL6Aj7LMGPrjmzDsE6gk5ChKlSYdVj+ut8w0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=uU+1Emt2kwIbv+OkATYjn5NOEx9bYE000TxrWQvUSco/PBP/9NpLOsFpWvDC69l+K yAujHFyr/dBqinZaKds/aEiW28DjVFcKMNoO5s70Jg11TYxDF4n3i/a/zroPg86Jd5 D3C3BNgK7dIIv6iAupm+QXqw+BvvgpUoE8Qp2SMY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727016AbgIYDKf (ORCPT ); Thu, 24 Sep 2020 23:10:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:54990 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726756AbgIYDKf (ORCPT ); Thu, 24 Sep 2020 23:10:35 -0400 Received: from X1 (unknown [104.245.68.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6D417206C1; Fri, 25 Sep 2020 03:10:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601003434; bh=Ds+x7kGYL6Aj7LMGPrjmzDsE6gk5ChKlSYdVj+ut8w0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jYwOpAwVfVctDlpMmjnjRUplgtiMt4mV/5scgwfkjbJ6Bo5ZjwM6v7bL0dquOqNJl cMP1JYdzy0PkLqhIbfblhX1qQY3EeW4keEDOoQtxsxTtwT6gF6md8ZIWvyY794zHBX tDCtAsNRAAu2pViXvPTs3EYpcv9VqpkEdfxURzr4= Date: Thu, 24 Sep 2020 20:10:33 -0700 From: Andrew Morton To: "Huang\, Ying" Cc: Rafael Aquini , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: swapfile: avoid split_swap_cluster() NULL pointer dereference Message-Id: <20200924201033.64e22c2915a8f2be3aacd97f@linux-foundation.org> In-Reply-To: <87v9g2blma.fsf@yhuang-dev.intel.com> References: <20200922184838.978540-1-aquini@redhat.com> <20200922124750.67a20d9764ec098b17705407@linux-foundation.org> <20200923134251.GN795820@optiplex-lnx> <20200924195914.d240877a10e22b457bd9b45d@linux-foundation.org> <87v9g2blma.fsf@yhuang-dev.intel.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 25 Sep 2020 11:06:53 +0800 "Huang\, Ying" wrote: > >> UGH! I missed adding it to my cc list. Shall I just forward it, now, or > >> do you prefer a fresh repost? > > > > I added the cc:stable to my copy. > > Please don't merge this patch. This patch doesn't fix the bug, but hide > the real bug. I will work with Rafael on root causing and fixing. Yup, I saw the discussion and have put the patch on hold pending the outcome.