From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=8iml=DC=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS
	autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 4E43BC4727E
	for <linux-kernel@archiver.kernel.org>; Fri, 25 Sep 2020 20:45:32 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 2310C206F7
	for <linux-kernel@archiver.kernel.org>; Fri, 25 Sep 2020 20:45:32 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1729112AbgIYUpa (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Fri, 25 Sep 2020 16:45:30 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55820 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1729060AbgIYUp0 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 25 Sep 2020 16:45:26 -0400
Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B900C0613CE;
        Fri, 25 Sep 2020 13:45:26 -0700 (PDT)
Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id BEB2B13B65D1E;
        Fri, 25 Sep 2020 13:28:37 -0700 (PDT)
Date:   Fri, 25 Sep 2020 13:45:22 -0700 (PDT)
Message-Id: <20200925.134522.130367831393016171.davem@davemloft.net>
To:     mfwitten@gmail.com
Cc:     sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] openprom: Fix 'opiocnextprop'; ensure integer
 conversions; use string size
From:   David Miller <davem@davemloft.net>
In-Reply-To: <859f327c79da4d9c945e50568805456c@gmail.com>
References: <a5515efeaad94666a87f264dbf65bdbd@gmail.com>
        <20200914.170321.1710628974878239639.davem@davemloft.net>
        <859f327c79da4d9c945e50568805456c@gmail.com>
X-Mailer: Mew version 6.8 on Emacs 27.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Fri, 25 Sep 2020 13:28:37 -0700 (PDT)
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Michael Witten <mfwitten@gmail.com>
Date: Fri, 25 Sep 2020 20:20:20 -0000

> Are we trying to improve the code or not?

Do you want me to apply your patch or not?

I want to see the most minimal code change necessary to fix the bug,
so we can easily backport it to -stable releases etc.

If you want to perform a variable name or other similar cosmetic
improvement, you can send a follow-up patch that does so.

Thank you.