From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E738BC4363D for ; Fri, 25 Sep 2020 16:30:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A5FAD206E5 for ; Fri, 25 Sep 2020 16:30:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729302AbgIYQaQ (ORCPT ); Fri, 25 Sep 2020 12:30:16 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:55656 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726990AbgIYQaQ (ORCPT ); Fri, 25 Sep 2020 12:30:16 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kLqbm-00GBRf-Ev; Fri, 25 Sep 2020 18:30:06 +0200 Date: Fri, 25 Sep 2020 18:30:06 +0200 From: Andrew Lunn To: Ivan Khoronzhuk Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org, alexander.sverdlin@nokia.com, linux-kernel@vger.kernel.org, Ivan Khoronzhuk Subject: Re: [PATCH] net: ethernet: cavium: octeon_mgmt: use phy_start and phy_stop Message-ID: <20200925163006.GB3856392@lunn.ch> References: <20200925124439.19946-1-ikhoronz@cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200925124439.19946-1-ikhoronz@cisco.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 25, 2020 at 03:44:39PM +0300, Ivan Khoronzhuk wrote: > To start also "phy state machine", with UP state as it should be, > the phy_start() has to be used, in another case machine even is not > triggered. After this change negotiation is supposed to be triggered > by SM workqueue. > > It's not correct usage, but it appears after the following patch, > so add it as a fix. > > Fixes: 74a992b3598a ("net: phy: add phy_check_link_status") > Signed-off-by: Ivan Khoronzhuk > --- > > Based on net/master Hi Ivan In the future, please make the patch subject [PATCH net] to make it clear which tree it is for. Reviewed-by: Andrew Lunn Andrew