From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D3C6C4741F for ; Sun, 27 Sep 2020 03:14:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D4A3217BA for ; Sun, 27 Sep 2020 03:14:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SLiKyRvG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730232AbgI0DOX (ORCPT ); Sat, 26 Sep 2020 23:14:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726478AbgI0DOW (ORCPT ); Sat, 26 Sep 2020 23:14:22 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4EA6C0613CE for ; Sat, 26 Sep 2020 20:14:22 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id mn7so1600659pjb.5 for ; Sat, 26 Sep 2020 20:14:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=l+d6MJHsVJnmGlH0O2IkJ1VifMVJbP89kc5QzKS4YXc=; b=SLiKyRvGZGWO+RQwPfkQ0TD1MCGeKiepuJsOrIsOaUpqc+4mfUy/SwoD554osUIbrk 3b+TgMvhH2GE6L/p60DhJRvN3mxTXQDd99ye4iXvxfChvSS1T0OSJs4+4y687fZzt8+C 5JMIPwwsGVM6FWuM0d0gwfmzUmji8Iq/ymXOv0EpIN2yUT5i5MC7xoXE7bNKET6+MlQ+ RykFNBEm60j0jXn9rtkNUpBWApxeZf0YyE7wpKR66MYZAUjF5AuNyh2JY3YErye+C67B Bd3tNy2Jkw87LDpjhSvStPeuSG4nUnsGv4SA+qifVQGoIEQDR9vMMng/JcgRvn24Kcip JEwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=l+d6MJHsVJnmGlH0O2IkJ1VifMVJbP89kc5QzKS4YXc=; b=naYfcZw7YxMacjfR5XilTcnfzKXwFnNXks+fLNscSJwrnTUNreolQ3OzhaptUbvQnZ 2FOU9TAWqeWEx0Wk2wttp+kjuIxS+MCzCKwX9SYKCMcbX4H2LsiAUtkayTnaJThe13gY CHooBcdBYPfC9dcdzVW0SAyhfhJ4bPKxx3MHMrNtZlzcsL2GPSQMHf13vQtSAMiVPr+k uE/XzTcsbGdRZdpQNmwKX83nCZ/eLdCFpWGtGZSvbkH9lw4BGlYa3rFITFY5+cKTP/wg rG9oFRjn9bFLXavkFaXBTrNckcbG7D2+EEslgO+5l44rfxF/cjXJLcYuaA0ZL41ABNm/ e2Zg== X-Gm-Message-State: AOAM530VYli69khfShp4QMRMzUQCaZgajFre+vx6sizKtFm5kIB7aFSY VCtLTmKO07tDcao+Cl+LKvOh X-Google-Smtp-Source: ABdhPJxppMQt/uFjVJXkCvar8TSf/LjNz7OulS16I1duHVfAZ7x1BK1/cFf4cUyCfoKFErbe6kwYOw== X-Received: by 2002:a17:90b:115:: with SMTP id p21mr4125594pjz.198.1601176462102; Sat, 26 Sep 2020 20:14:22 -0700 (PDT) Received: from Mani-XPS-13-9360 ([2409:4072:198:cd53:8f:5b5c:829a:cfde]) by smtp.gmail.com with ESMTPSA id k11sm2989080pjs.18.2020.09.26.20.14.18 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 26 Sep 2020 20:14:21 -0700 (PDT) Date: Sun, 27 Sep 2020 08:44:15 +0530 From: Manivannan Sadhasivam To: Hemant Kumar Cc: gregkh@linuxfoundation.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, jhugo@codeaurora.org, bbhatt@codeaurora.org Subject: Re: [PATCH v6 2/4] bus: mhi: core: Move MHI_MAX_MTU to external header file Message-ID: <20200927031415.GE3213@Mani-XPS-13-9360> References: <1600286167-4432-1-git-send-email-hemantk@codeaurora.org> <1600286167-4432-3-git-send-email-hemantk@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1600286167-4432-3-git-send-email-hemantk@codeaurora.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 16, 2020 at 12:56:05PM -0700, Hemant Kumar wrote: > Currently this macro is defined in internal MHI header as > a TRE length mask. Moving it to external header allows MHI > client drivers to set this upper bound for the transmit > buffer size. > > Signed-off-by: Hemant Kumar Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- > drivers/bus/mhi/core/internal.h | 1 - > include/linux/mhi.h | 3 +++ > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/bus/mhi/core/internal.h b/drivers/bus/mhi/core/internal.h > index 7989269..4abf0cf 100644 > --- a/drivers/bus/mhi/core/internal.h > +++ b/drivers/bus/mhi/core/internal.h > @@ -453,7 +453,6 @@ enum mhi_pm_state { > #define CMD_EL_PER_RING 128 > #define PRIMARY_CMD_RING 0 > #define MHI_DEV_WAKE_DB 127 > -#define MHI_MAX_MTU 0xffff > #define MHI_RANDOM_U32_NONZERO(bmsk) (prandom_u32_max(bmsk) + 1) > > enum mhi_er_type { > diff --git a/include/linux/mhi.h b/include/linux/mhi.h > index 6565528..610f3b0 100644 > --- a/include/linux/mhi.h > +++ b/include/linux/mhi.h > @@ -16,6 +16,9 @@ > #include > #include > > +/* MHI client drivers to set this upper bound for tx buffer */ > +#define MHI_MAX_MTU 0xffff > + > #define MHI_MAX_OEM_PK_HASH_SEGMENTS 16 > > struct mhi_chan; > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >