From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51699C4727E for ; Sun, 27 Sep 2020 10:23:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 13C7C23977 for ; Sun, 27 Sep 2020 10:23:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601202182; bh=CqLwxaQAm8VgPpIJfqcU6NKANuRG4GyWBpOvkI5a1yI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=HQ4AQP4cOugwpmU02r1vn4IhISTamBN3qC2N9ZkRBmtJLUTXOqx2SWhgvCmVKOXRH ++MPXI0dXlfnGrvuzFSI2NSe1ut2hldcxyOWeJsx1nNU3StUgHwValV4Y9tp+u93iv QoP4nD0zaY8ae9nS5DDxWyksSv2dU1mt9gkRYNNk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726380AbgI0KXB (ORCPT ); Sun, 27 Sep 2020 06:23:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:34598 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726239AbgI0KXA (ORCPT ); Sun, 27 Sep 2020 06:23:00 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AD2F523977; Sun, 27 Sep 2020 10:22:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601202180; bh=CqLwxaQAm8VgPpIJfqcU6NKANuRG4GyWBpOvkI5a1yI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SsqZZ8s9H2sSMoZXm4bjECLL0VJEjXWOsElk7M8QynIJFnXJJyt0Lez8OpURGuf9p 4KEJsyNLBfIlU0eK+i/m4ExTDnB20e2sVjHHQCQuD8WvZFNQNSylkkYK1LR8poUrTq WZMZC+bNyEZk+VAOdukv1qVY2k1BfLWtxOCJvfAw= Date: Sun, 27 Sep 2020 12:23:10 +0200 From: Greg KH To: Manivannan Sadhasivam Cc: hemantk@codeaurora.org, bbhatt@codeaurora.org, linux-arm-msm@vger.kernel.org, jhugo@codeaurora.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] bus: mhi: core: debugfs: Use correct format specifiers for addresses Message-ID: <20200927102310.GB87283@kroah.com> References: <20200927033652.11789-1-manivannan.sadhasivam@linaro.org> <20200927033652.11789-2-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200927033652.11789-2-manivannan.sadhasivam@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 27, 2020 at 09:06:48AM +0530, Manivannan Sadhasivam wrote: > For exposing the addresses of read/write pointers and doorbell register, > let's use the correct format specifiers. This fixes the following issues > generated using W=1 build in ARM32 and reported by Kbuild bot: > > All warnings (new ones prefixed by >>): > > >> drivers/bus/mhi/core/debugfs.c:75:7: warning: format specifies type 'unsigned long long' but the argument has type 'dma_addr_t' (aka 'unsigned int') [-Wformat] > mhi_event->db_cfg.db_val); > ^~~~~~~~~~~~~~~~~~~~~~~~ > drivers/bus/mhi/core/debugfs.c:123:7: warning: format specifies type 'unsigned long long' but the argument has type 'dma_addr_t' (aka 'unsigned int') [-Wformat] > mhi_chan->db_cfg.db_val); > ^~~~~~~~~~~~~~~~~~~~~~~ > 2 warnings generated. > > drivers/bus/mhi/core/debugfs.c: In function ‘mhi_debugfs_events_show’: > drivers/bus/mhi/core/debugfs.c:74:51: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] > seq_printf(m, " local rp: 0x%llx db: 0x%pad\n", (u64)ring->rp, > ^ > drivers/bus/mhi/core/debugfs.c: In function ‘mhi_debugfs_channels_show’: > drivers/bus/mhi/core/debugfs.c:122:7: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] > (u64)ring->rp, (u64)ring->wp, > ^ > drivers/bus/mhi/core/debugfs.c:122:22: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] > (u64)ring->rp, (u64)ring->wp, > ^ > drivers/bus/mhi/core/debugfs.c:121:62: warning: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 5 has type ‘dma_addr_t {aka unsigned int}’ [-Wformat=] > seq_printf(m, " local rp: 0x%llx local wp: 0x%llx db: 0x%llx\n", > ~~~^ > %x > drivers/bus/mhi/core/debugfs.c:123:7: > mhi_chan->db_cfg.db_val); > > Reported-by: kernel test robot > Signed-off-by: Manivannan Sadhasivam > --- > drivers/bus/mhi/core/debugfs.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) Ah, this is against your first set of patches, that's the confusion on my part. Please just fix them all up and resend 1 series of patches, that isn't broken, and I will be glad to review and take that. thanks, greg k-h