From: Christoph Hellwig <hch@infradead.org>
To: Sherry Sun <sherry.sun@nxp.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"sudeep.dutt@intel.com" <sudeep.dutt@intel.com>,
"ashutosh.dixit@intel.com" <ashutosh.dixit@intel.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"wang.yi59@zte.com.cn" <wang.yi59@zte.com.cn>,
"rikard.falkeborn@gmail.com" <rikard.falkeborn@gmail.com>,
"lee.jones@linaro.org" <lee.jones@linaro.org>,
"mst@redhat.com" <mst@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH 4/5] misc: vop: set VIRTIO_F_ACCESS_PLATFORM for nocoherent platform
Date: Mon, 28 Sep 2020 07:09:17 +0100 [thread overview]
Message-ID: <20200928060917.GB9387@infradead.org> (raw)
In-Reply-To: <VI1PR04MB49604A96195B07032826B0AA92340@VI1PR04MB4960.eurprd04.prod.outlook.com>
On Sun, Sep 27, 2020 at 08:05:07AM +0000, Sherry Sun wrote:
> Hi Christoph,
>
> > On Fri, Sep 25, 2020 at 03:26:29PM +0800, Sherry Sun wrote:
> > > Set VIRTIO_F_ACCESS_PLATFORM feature for nocoherent platform, since it
> > > needs the DMA API for virtio.
> >
> > Given that VOP is a plug-in PCIe card VIRTIO_F_ACCESS_PLATFORM must
> > always be set, as the DMA mapping details are not something the virtio
> > implementation decides on, but the host PCIe/iommu implementation.
>
> So do you mean that we should remove the check, and set VIRTIO_F_ACCESS_PLATFORM feature directly?
Yes. In a separate prep patch.
next prev parent reply other threads:[~2020-09-28 6:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 7:26 [PATCH 0/5] Add noncoherent platform support for vop driver Sherry Sun
2020-09-25 7:26 ` [PATCH 1/5] misc: vop: change the way of allocating vring for noncoherent platform Sherry Sun
2020-09-25 12:16 ` Greg KH
2020-09-27 7:06 ` Sherry Sun
2020-09-26 7:50 ` Christoph Hellwig
2020-09-27 7:58 ` Sherry Sun
2020-09-28 6:09 ` Christoph Hellwig
2020-09-28 10:10 ` Sherry Sun
2020-09-25 7:26 ` [PATCH 2/5] misc: vop: change the way of allocating used ring Sherry Sun
2020-09-25 7:26 ` [PATCH 3/5] misc: vop: simply return the saved dma address instead of virt_to_phys Sherry Sun
2020-09-25 12:17 ` Greg KH
2020-09-27 7:23 ` Sherry Sun
2020-09-25 7:26 ` [PATCH 4/5] misc: vop: set VIRTIO_F_ACCESS_PLATFORM for nocoherent platform Sherry Sun
2020-09-25 12:16 ` Greg KH
2020-09-27 7:20 ` Sherry Sun
2020-09-26 7:51 ` Christoph Hellwig
2020-09-27 8:05 ` Sherry Sun
2020-09-28 6:09 ` Christoph Hellwig [this message]
2020-09-28 9:57 ` Sherry Sun
2020-09-25 7:26 ` [PATCH 5/5] misc: vop: mapping kernel memory to user space as noncached Sherry Sun
2020-09-25 11:25 ` [PATCH 0/5] Add noncoherent platform support for vop driver Arnd Bergmann
2020-09-27 5:07 ` Sherry Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200928060917.GB9387@infradead.org \
--to=hch@infradead.org \
--cc=arnd@arndb.de \
--cc=ashutosh.dixit@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=rikard.falkeborn@gmail.com \
--cc=sherry.sun@nxp.com \
--cc=sudeep.dutt@intel.com \
--cc=wang.yi59@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®