From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B773EC2D0A8 for ; Mon, 28 Sep 2020 12:41:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 518D121531 for ; Mon, 28 Sep 2020 12:41:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="fhtQRRd3"; dkim=temperror (0-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="M11zvvl2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726638AbgI1MlY (ORCPT ); Mon, 28 Sep 2020 08:41:24 -0400 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:38751 "EHLO wout5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726393AbgI1MlX (ORCPT ); Mon, 28 Sep 2020 08:41:23 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 4B38AE1D; Mon, 28 Sep 2020 08:33:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 28 Sep 2020 08:33:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=aKbOhNy9O2gXF53DyoY1hssn0Et zT/U677Ue5Zp2lUw=; b=fhtQRRd394LH2wCT02PYVBpKo5fQ5GAt1naEWo3fxrr R/nykLWc4Yck9K5GiHUgiRCGYV5fgwwT3FvmrO4pT0MjtZZohJiJMwo/D0foKFMd GiUqDCsdLg/OoWzcQwPlSQBXIkUKyAywjSDinZGJ9Iuc0knPsBbpwuXZt5IWj+Pp gzfk3Kfu38LHKVBRlsKNs/uLHoGTcncPCEGZ99vDwx3NlI5D8WRArWNf8hD0CQ43 bgTtwaAkUQstDDTk2VXdVohrr2B+8WwqTELfCBkVQta/+74QcFgehX4+v6Ud/RPk cDH3FK9igyV3Yvk8wy9i/7C9i3SjWpAXT1Cpo/7rA1A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=aKbOhN y9O2gXF53DyoY1hssn0EtzT/U677Ue5Zp2lUw=; b=M11zvvl28t+SWegiG9mZ+0 3J9Yf2yVgzQeRplml/P35qAPPXu4agWRsdTHD+E3pkDMCG6uNga7m4+h8RN3a+HN waJxqnmQitwA+F8cvB6yEgFm7iG8p0UfhBrSf9LHfOxPGjzR2+mMdxt+d9a5LLCf mz3Gutrtk8qYZdwkms2a/363qPiSYUrFjvnyaFdkZvr0vho3I3NCYab9Nt3wqFG2 /7lCnm6p9S1s/UYSescTcmr2tp9uYpyZjxHAAaKGPy494Jrwou8Im2ZzQUc+3Wxt 19lDPYGBBlckf272LQUY3Zh1h+zB4+gyVXUtPb1zQpbECJuWr2eqa8w/OoMm2QKQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrvdeigdeflecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtuggjsehttdertd dttddvnecuhfhrohhmpefirhgvghcumffjuceoghhrvghgsehkrhhorghhrdgtohhmqeen ucggtffrrghtthgvrhhnpeeuffejudeutdeluedtledvgefgueevjeefkedvudfhlefhfe dvgeefgfeijeejgeenucffohhmrghinhepkhgvrhhnvghlrdhorhhgpdhsuhhsvgdrtgho mhdpshgvrhhvvghrfhgruhhlthdrtghomhdplhgruhhntghhphgrugdrnhgvthdptggvnh htohhsrdhorhhgnecukfhppeekfedrkeeirdejgedrieegnecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghhrvghgsehkrhhorghhrdgtohhm X-ME-Proxy: Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) by mail.messagingengine.com (Postfix) with ESMTPA id 349B53064682; Mon, 28 Sep 2020 08:33:31 -0400 (EDT) Date: Mon, 28 Sep 2020 14:33:40 +0200 From: Greg KH To: linux-kernel@vger.kernel.org Cc: jslaby@suse.cz, stable-commits@vger.kernel.org Subject: Re: Patch "ata: sata_mv, avoid trigerrable BUG_ON" has been added to the 4.4-stable tree Message-ID: <20200928123340.GB1116804@kroah.com> References: <20200927181119.5ACB623A33@mail.kernel.org> <20200928123057.GA1116804@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200928123057.GA1116804@kroah.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 28, 2020 at 02:30:57PM +0200, Greg KH wrote: > On Sun, Sep 27, 2020 at 02:11:18PM -0400, Sasha Levin wrote: > > This is a note to let you know that I've just added the patch titled > > > > ata: sata_mv, avoid trigerrable BUG_ON > > > > to the 4.4-stable tree which can be found at: > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > > > The filename of the patch is: > > ata-sata_mv-avoid-trigerrable-bug_on.patch > > and it can be found in the queue-4.4 subdirectory. > > > > If you, or anyone else, feels it should not be added to the stable tree, > > please let know about it. > > > > > > > > commit 4b308d858a1a34dae1e38948f2c0497161d9ddd8 > > Author: Jiri Slaby > > Date: Thu Oct 31 10:59:46 2019 +0100 > > > > ata: sata_mv, avoid trigerrable BUG_ON > > > > [ Upstream commit e9f691d899188679746eeb96e6cb520459eda9b4 ] > > > > There are several reports that the BUG_ON on unsupported command in > > mv_qc_prep can be triggered under some circumstances: > > https://bugzilla.suse.com/show_bug.cgi?id=1110252 > > https://serverfault.com/questions/888897/raid-problems-after-power-outage > > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1652185 > > https://bugs.centos.org/view.php?id=14998 > > > > Let sata_mv handle the failure gracefully: warn about that incl. the > > failed command number and return an AC_ERR_INVALID error. We can do that > > now thanks to the previous patch. > > > > Remove also the long-standing FIXME. > > > > [v2] use %.2x as commands are defined as hexa. > > > > Signed-off-by: Jiri Slaby > > Cc: Jens Axboe > > Cc: linux-ide@vger.kernel.org > > Cc: Sergei Shtylyov > > Signed-off-by: Jens Axboe > > Signed-off-by: Sasha Levin > > > > diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c > > index 729f26322095e..c24bbdb3f76c8 100644 > > --- a/drivers/ata/sata_mv.c > > +++ b/drivers/ata/sata_mv.c > > @@ -2113,12 +2113,10 @@ static void mv_qc_prep(struct ata_queued_cmd *qc) > > * non-NCQ mode are: [RW] STREAM DMA and W DMA FUA EXT, none > > * of which are defined/used by Linux. If we get here, this > > * driver needs work. > > - * > > - * FIXME: modify libata to give qc_prep a return value and > > - * return error here. > > */ > > - BUG_ON(tf->command); > > - break; > > + ata_port_err(ap, "%s: unsupported command: %.2x\n", __func__, > > + tf->command); > > + return AC_ERR_INVALID; > > } > > mv_crqb_pack_cmd(cw++, tf->nsect, ATA_REG_NSECT, 0); > > mv_crqb_pack_cmd(cw++, tf->hob_lbal, ATA_REG_LBAL, 0); > > This causes a build warning as you can not return a value for a void > function :( > > I'll drop it from the 4.4 queue now, thanks, Also dropped from 4.9, 4.14, 4.19, and 5.4 queues for the same issue. thanks, greg k-h