From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 858DEC2D0A8 for ; Mon, 28 Sep 2020 19:26:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 360192071E for ; Mon, 28 Sep 2020 19:26:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726755AbgI1T0V (ORCPT ); Mon, 28 Sep 2020 15:26:21 -0400 Received: from mga04.intel.com ([192.55.52.120]:6527 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726701AbgI1T0U (ORCPT ); Mon, 28 Sep 2020 15:26:20 -0400 IronPort-SDR: dz+3gIky+tAqHpSoOlqdLItkwdKY/wSz/ZLqy/jCRtIhQormb5Ft9HcUI0ytCpMiKeNkapXjyn 4Gu4HfyVCKow== X-IronPort-AV: E=McAfee;i="6000,8403,9758"; a="159428881" X-IronPort-AV: E=Sophos;i="5.77,315,1596524400"; d="scan'208";a="159428881" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2020 12:26:19 -0700 IronPort-SDR: TzX6TFCO5L2u0GF5oYraSXfcLVFcpO2leA/f1u4+7rdsT6EVUjArJr5XKfm3TVjvL0vzo2UVHi in4R+0hBM8CA== X-IronPort-AV: E=Sophos;i="5.77,315,1596524400"; d="scan'208";a="456961657" Received: from iweiny-desk2.sc.intel.com (HELO localhost) ([10.3.52.147]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2020 12:26:19 -0700 Date: Mon, 28 Sep 2020 12:26:19 -0700 From: Ira Weiny To: John Hubbard Cc: Andrew Morton , Jonathan Corbet , =?iso-8859-1?B?Suly9G1l?= Glisse , Ralph Campbell , Shuah Khan , LKML , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, linux-s390@vger.kernel.org Subject: Re: [PATCH 7/8] selftests/vm: run_vmtest.sh: update and clean up gup_test invocation Message-ID: <20200928192619.GF458519@iweiny-DESK2.sc.intel.com> References: <20200928062159.923212-1-jhubbard@nvidia.com> <20200928062159.923212-8-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200928062159.923212-8-jhubbard@nvidia.com> User-Agent: Mutt/1.11.1 (2018-12-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 27, 2020 at 11:21:58PM -0700, John Hubbard wrote: > Run benchmarks on the _fast variants of gup and pup, as originally > intended. > > Run the new gup_test sub-test: dump pages. In addition to exercising the > dump_page() call, it also demonstrates the various options you can use > to specify which pages to dump, and how. > > Signed-off-by: John Hubbard > --- > tools/testing/selftests/vm/run_vmtest.sh | 24 ++++++++++++++++++------ > 1 file changed, 18 insertions(+), 6 deletions(-) > > diff --git a/tools/testing/selftests/vm/run_vmtest.sh b/tools/testing/selftests/vm/run_vmtest.sh > index d1843d5f3c30..e3a8b14d9df6 100755 > --- a/tools/testing/selftests/vm/run_vmtest.sh > +++ b/tools/testing/selftests/vm/run_vmtest.sh > @@ -124,9 +124,9 @@ else > fi > > echo "--------------------------------------------" > -echo "running 'gup_test -U' (normal/slow gup)" > +echo "running 'gup_test -u' (fast gup benchmark)" > echo "--------------------------------------------" > -./gup_test -U > +./gup_test -u > if [ $? -ne 0 ]; then > echo "[FAIL]" > exitcode=1 > @@ -134,10 +134,22 @@ else > echo "[PASS]" > fi > > -echo "------------------------------------------" > -echo "running gup_test -b (pin_user_pages)" > -echo "------------------------------------------" > -./gup_test -b > +echo "---------------------------------------------------" > +echo "running gup_test -a (pin_user_pages_fast benchmark)" > +echo "---------------------------------------------------" > +./gup_test -a > +if [ $? -ne 0 ]; then > + echo "[FAIL]" > + exitcode=1 > +else > + echo "[PASS]" > +fi > + > +echo "--------------------------------------------------------------" > +echo "running gup_test -ct -F 0x1 0 19 0x1000" > +echo " Dumps pages 0, 19, and 4096, using pin_user_pages (-F 0x1)" > +echo "--------------------------------------------------------------" > +./gup_test -ct -F 0x1 0 19 0x1000 Ah here it is... Maybe just remove that from the previous commit message. Ira > if [ $? -ne 0 ]; then > echo "[FAIL]" > exitcode=1 > -- > 2.28.0 > >