From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6200CC4727C for ; Tue, 29 Sep 2020 19:54:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 017C720848 for ; Tue, 29 Sep 2020 19:53:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="PM6IZxPJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728851AbgI2Tx6 (ORCPT ); Tue, 29 Sep 2020 15:53:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727700AbgI2Tx6 (ORCPT ); Tue, 29 Sep 2020 15:53:58 -0400 Received: from mail-qt1-x844.google.com (mail-qt1-x844.google.com [IPv6:2607:f8b0:4864:20::844]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 204E7C061755 for ; Tue, 29 Sep 2020 12:53:58 -0700 (PDT) Received: by mail-qt1-x844.google.com with SMTP id k25so4654192qtu.4 for ; Tue, 29 Sep 2020 12:53:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3mRajUIo4XOPD3LXyp5jDugEU5fV0eJ4P4CT7IZza1k=; b=PM6IZxPJuaxo3YsUROHrk+LFZrIuZBkuiJUqbgk6s/7FM110mjvX+XKO+hwjH4iHxs /GvBYPiPVoIi1da7WKtiHzwvL0VL71aYCm2twizjNLwo6yd7+iSBVJtfn3JyiNPDgp3r ozlZg/bNaujXv/xbVf00OPrjIgQYiDuQ8pWMPhWy02DNIWW7Z3ZW20OrcjXXVopmH6qa iC5vcXudPZdFvg7ocAKFfWUYJ0TlkooLKa/OMPqnsMHPcug7fQ7vPJ6Ag7edxGv0k51d XMw3/5qURiqjXiFQrLZweYGuGV85XSDjdHGJWuoeLWo/zkMxlVeUn/F1dDMrhIeH+9gc 0OuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3mRajUIo4XOPD3LXyp5jDugEU5fV0eJ4P4CT7IZza1k=; b=td+GsuDAcP+AEsPiUdArEH/6FLvnFA5nMadz3aYYCseWFAcyM4fTAGqMWH440PgbNq uCHzev8umR61rqhW9TiCrCskaaVGDUCzEZmCUNk2Y/nsjevFllaFy7Fo8UErAUCXZ73j hYYlqfSU7dpjSurwdySWpA6Rh6O69qUotBftj5Dsmf6TErfrHozBdSDqavuyo1z10DLB g6D9CT9MZwH88S6fZCCp0up24E3E3ydOwfzrnEsCXkVA5wz71HSJmjIswaXLnncExv+l 7KIsnesnhhKgxizm9O3TXkZ//Lk4iZqxR3mvUduFo83fw13kEfmZJuY4gY2TvoI8o/pk 7z6g== X-Gm-Message-State: AOAM533jt0+oo09mqUG1+/J8QefR6sVCo3I+Jz7VI7ajwADI/4nNKkmd CbkEBXGDyOWIo+rR1SLBx2I83A== X-Google-Smtp-Source: ABdhPJz8dZwJGVGgqnvNCaakOsX+4PEGTifP8JSz4ukCPx2Qp5OPg1bkTA0k/vzC6egTBA6VrjFJ3Q== X-Received: by 2002:ac8:774f:: with SMTP id g15mr4923587qtu.294.1601409237342; Tue, 29 Sep 2020 12:53:57 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id v18sm6425459qtq.15.2020.09.29.12.53.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Sep 2020 12:53:56 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kNLhE-003G4U-1G; Tue, 29 Sep 2020 16:53:56 -0300 Date: Tue, 29 Sep 2020 16:53:56 -0300 From: Jason Gunthorpe To: John Hubbard Cc: Andrew Morton , Jonathan Corbet , =?utf-8?B?SsOpcsO0bWU=?= Glisse , Ralph Campbell , Shuah Khan , LKML , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, linux-s390@vger.kernel.org Subject: Re: [PATCH 2/8] selftests/vm: use a common gup_test.h Message-ID: <20200929195356.GZ9916@ziepe.ca> References: <20200928062159.923212-1-jhubbard@nvidia.com> <20200928062159.923212-3-jhubbard@nvidia.com> <20200928125739.GP9916@ziepe.ca> <6481e78f-c70d-133a-ff4a-325b5cd8fd5d@nvidia.com> <20200929163507.GV9916@ziepe.ca> <20200929175524.GX9916@ziepe.ca> <715c49ec-d2a8-45cb-8ace-c6b1b4b8f978@nvidia.com> <20200929190816.GY9916@ziepe.ca> <3022912c-f11b-f564-3a8a-f516ca259a37@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3022912c-f11b-f564-3a8a-f516ca259a37@nvidia.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 29, 2020 at 12:48:43PM -0700, John Hubbard wrote: > On 9/29/20 12:08 PM, Jason Gunthorpe wrote: > > On Tue, Sep 29, 2020 at 11:59:55AM -0700, John Hubbard wrote: > > > On 9/29/20 10:55 AM, Jason Gunthorpe wrote: > > > > On Tue, Sep 29, 2020 at 10:44:31AM -0700, John Hubbard wrote: > > > > > On 9/29/20 9:35 AM, Jason Gunthorpe wrote: > > > > > > On Mon, Sep 28, 2020 at 01:10:24PM -0700, John Hubbard wrote: > > > > > > > On 9/28/20 5:57 AM, Jason Gunthorpe wrote: > > > > > > > > On Sun, Sep 27, 2020 at 11:21:53PM -0700, John Hubbard wrote: > > > ... > > > > > I don't see any "gcc -m" type of dependency generation pass happening > > > > > in this relatively simple Make system. > > > > > > > > It happens with -MD, all the deps are stored in files like mm/.init-mm.o.cmd > > > > and sucked into the build. > > > > > > You are thinking of kbuild. This is not kbuild. There are no such artifacts > > > being generated. > > > > Oh. Really? That's horrible. > > > > Well, yes, it's not a perfect build system down here in selftests/. Are you saying > that it is worth upgrading? I'm open to suggestions and ideas for improvements, > and at the moment, I have the miniature build system here mostly loaded into my > head. So for a brief shining moment I can probably understand it well enough to > work on it. :) I only remarked because I didn't know it wasn't using kbuild. I thought it would have used the existing HOSTCC stuff, not sure why it is special. The only investment that seems worthwhile would be to switch it to use the normal kbuild stuff?? Jason