From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0B45C4741F for ; Wed, 30 Sep 2020 17:11:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 794982076B for ; Wed, 30 Sep 2020 17:11:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731346AbgI3RLw (ORCPT ); Wed, 30 Sep 2020 13:11:52 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:57188 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725385AbgI3RLw (ORCPT ); Wed, 30 Sep 2020 13:11:52 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 4CA231C0B81; Wed, 30 Sep 2020 19:11:48 +0200 (CEST) Date: Wed, 30 Sep 2020 19:11:47 +0200 From: Pavel Machek To: Marek =?iso-8859-1?Q?Beh=FAn?= Cc: Tobias Jordan , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Dan Murphy , Jean-Jacques Hiblot , Tomi Valkeinen Subject: Re: [PATCH v2] leds: tlc591xx: fix leak of device node iterator Message-ID: <20200930171147.GG27760@duo.ucw.cz> References: <20200926005117.GA32209@agrajag.zerfleddert.de> <20200926032406.00c7cfb2@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="doKZ0ri6bHmN2Q5y" Content-Disposition: inline In-Reply-To: <20200926032406.00c7cfb2@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --doKZ0ri6bHmN2Q5y Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > In one of the error paths of the for_each_child_of_node loop in > > tlc591xx_probe, add missing call to of_node_put. > >=20 > > Fixes: 1ab4531ad132 ("leds: tlc591xx: simplify driver by using the > > managed led API") > >=20 > > Signed-off-by: Tobias Jordan >=20 > Reviewed-by: Marek Beh=FAn Thanks, applied. Marek: Thanks for review. If I can get you to trim parts not interesting for the email, I'll be even happier. :-). Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --doKZ0ri6bHmN2Q5y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCX3S8UwAKCRAw5/Bqldv6 8sGjAJ4p4WWc5e3h1dnOH15zoZ6BkKqEuwCgj4CZR2QoQTFl1EemE7FZu+L781s= =2qtW -----END PGP SIGNATURE----- --doKZ0ri6bHmN2Q5y--