From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61C5CC47420 for ; Thu, 1 Oct 2020 10:20:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 223AD21481 for ; Thu, 1 Oct 2020 10:20:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731925AbgJAKT7 (ORCPT ); Thu, 1 Oct 2020 06:19:59 -0400 Received: from mx2.suse.de ([195.135.220.15]:47458 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725938AbgJAKT6 (ORCPT ); Thu, 1 Oct 2020 06:19:58 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A50E6ABBD; Thu, 1 Oct 2020 10:19:56 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 901EFDA781; Thu, 1 Oct 2020 12:18:33 +0200 (CEST) Date: Thu, 1 Oct 2020 12:18:33 +0200 From: David Sterba To: Nick Terrell Cc: Nick Terrell , Herbert Xu , "linux-crypto@vger.kernel.org" , Btrfs BTRFS , "squashfs-devel@lists.sourceforge.net" , "linux-f2fs-devel@lists.sourceforge.net" , Linux Kernel Mailing List , Kernel Team , Chris Mason , Petr Malat , Johannes Weiner , Niket Agarwal , Yann Collet , Christoph Hellwig Subject: Re: [GIT PULL][PATCH v4 0/9] Update to zstd-1.4.6 Message-ID: <20201001101833.GT6756@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Nick Terrell , Nick Terrell , Herbert Xu , "linux-crypto@vger.kernel.org" , Btrfs BTRFS , "squashfs-devel@lists.sourceforge.net" , "linux-f2fs-devel@lists.sourceforge.net" , Linux Kernel Mailing List , Kernel Team , Chris Mason , Petr Malat , Johannes Weiner , Niket Agarwal , Yann Collet , Christoph Hellwig References: <20200930065318.3326526-1-nickrterrell@gmail.com> <293CD1BC-DBED-4344-AC84-C85E0DD7914D@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <293CD1BC-DBED-4344-AC84-C85E0DD7914D@fb.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 30, 2020 at 08:49:49PM +0000, Nick Terrell wrote: > > On Sep 29, 2020, at 11:53 PM, Nick Terrell wrote: > > > > From: Nick Terrell > > It has been brought to my attention that patch 3 hasn’t made it to patchwork, > likely because it is too large. I’ll include a pull request in the next cover letter, > together with the patches (if needed). The patch 3/9 saved to a file is 1.6M, over 35000 lines, the diffstat says: 66 files changed, 24268 insertions(+), 12889 deletions(-) Seriously, this is wrong in so many ways. There's the rationale for one-time change etc, but the actual result is beyond what I would accept and would not encourage anyone to merge as-is.