mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	Jacopo Mondi <jacopo@jmondi.org>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media <linux-media@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Biju Das <biju.das.jz@bp.renesas.com>
Subject: Re: [PATCH v6 1/3] media: i2c: ov772x: Parse endpoint properties
Date: Thu, 1 Oct 2020 22:34:14 +0300	[thread overview]
Message-ID: <20201001193413.GR26842@paasikivi.fi.intel.com> (raw)
In-Reply-To: <CA+V-a8t5piG4a0C2BKgsZii6EB7te=GUeRCmfcPhdm+hAuV7Ng@mail.gmail.com>

On Wed, Sep 30, 2020 at 01:19:40PM +0100, Lad, Prabhakar wrote:
> HI Sakari,
> 
> Thank you for the review.
> 
> On Wed, Sep 30, 2020 at 12:45 PM Sakari Ailus
> <sakari.ailus@linux.intel.com> wrote:
> >
> > Hi Prabhakar,
> >
> > On Thu, Sep 17, 2020 at 06:42:22PM +0100, Lad Prabhakar wrote:
> > > Parse endpoint properties using v4l2_fwnode_endpoint_alloc_parse()
> > > to determine the bus type and store it in the driver structure.
> > >
> > > Set bus_type to V4L2_MBUS_PARALLEL as it's the only supported one
> > >
> > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > ---
> > >  drivers/media/i2c/ov772x.c | 34 ++++++++++++++++++++++++++++++++++
> > >  1 file changed, 34 insertions(+)
> > >
> > > diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov772x.c
> > > index 2cc6a678069a..f61a3f09ad64 100644
> > > --- a/drivers/media/i2c/ov772x.c
> > > +++ b/drivers/media/i2c/ov772x.c
> > > @@ -31,6 +31,7 @@
> > >  #include <media/v4l2-ctrls.h>
> > >  #include <media/v4l2-device.h>
> > >  #include <media/v4l2-event.h>
> > > +#include <media/v4l2-fwnode.h>
> > >  #include <media/v4l2-image-sizes.h>
> > >  #include <media/v4l2-subdev.h>
> > >
> > > @@ -434,6 +435,7 @@ struct ov772x_priv {
> > >  #ifdef CONFIG_MEDIA_CONTROLLER
> > >       struct media_pad pad;
> > >  #endif
> > > +     enum v4l2_mbus_type               bus_type;
> > >  };
> > >
> > >  /*
> > > @@ -1348,6 +1350,34 @@ static const struct v4l2_subdev_ops ov772x_subdev_ops = {
> > >       .pad    = &ov772x_subdev_pad_ops,
> > >  };
> > >
> > > +static int ov772x_parse_dt(struct i2c_client *client,
> > > +                        struct ov772x_priv *priv)
> > > +{
> > > +     struct v4l2_fwnode_endpoint bus_cfg;
> > > +     struct fwnode_handle *ep;
> > > +     int ret;
> > > +
> > > +     ep = fwnode_graph_get_next_endpoint(dev_fwnode(&client->dev),
> > > +                                         NULL);
> > > +     if (!ep) {
> > > +             dev_err(&client->dev, "Endpoint node not found\n");
> > > +             return -EINVAL;
> > > +     }
> > > +
> > > +     bus_cfg.bus_type = V4L2_MBUS_PARALLEL;
> >
> > Please zero the entire struct, i.e. do this assignment in the declaration.
> >
> Agreed, but instead at the declaration I would prefer here as below,
> since patch 2/3 has a comment related to backward compatibility with
> the bindings. Is this OK with you ?
>     bus_cfg = (struct v4l2_fwnode_endpoint)
>           { .bus_type = V4L2_MBUS_PARALLEL };

Why not in variable declaration?

-- 
Sakari Ailus

  reply	other threads:[~2020-10-01 19:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-17 17:42 [PATCH v6 0/3] media: i2c: ov772x: Enable BT.656 mode and test pattern support Lad Prabhakar
2020-09-17 17:42 ` [PATCH v6 1/3] media: i2c: ov772x: Parse endpoint properties Lad Prabhakar
2020-09-30 10:30   ` Jacopo Mondi
2020-09-30 11:45   ` Sakari Ailus
2020-09-30 12:19     ` Lad, Prabhakar
2020-10-01 19:34       ` Sakari Ailus [this message]
2020-09-17 17:42 ` [PATCH v6 2/3] media: i2c: ov772x: Add support for BT.656 mode Lad Prabhakar
2020-09-30 10:32   ` Jacopo Mondi
2020-09-17 17:42 ` [PATCH v6 3/3] media: i2c: ov772x: Add test pattern control Lad Prabhakar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201001193413.GR26842@paasikivi.fi.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=jacopo@jmondi.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=prabhakar.csengg@gmail.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®