mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roman Gushchin <guro@fb.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Bastian Bittorf <bb@npl.de>, Vlastimil Babka <vbabka@suse.cz>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux 5.9-rc7 / VmallocTotal wrongly reported
Date: Thu, 1 Oct 2020 12:56:10 -0700	[thread overview]
Message-ID: <20201001195610.GC2706729@carbon.DHCP.thefacebook.com> (raw)
In-Reply-To: <CAHk-=wixd9kUup4o1d1y9Wg9WoRt6_mN7kM5sPX=_nrgrkZzFg@mail.gmail.com>

On Thu, Oct 01, 2020 at 12:19:57PM -0700, Linus Torvalds wrote:
> Adding Vlastimil, Roman and the kernel mailing list to the cc.
> 
> Vlastimil, Roman - this looks like a slab regression. And while others
> have touched slab in this merge window, you guys did so more than
> most.. Comments?

Thank you, Linus!

I think it's a regression from my slab controller changes, and I have a theory.
Bastian, can you, please, share your config?

I will come up with a patch soon.

Thanks!

> 
> On Wed, Sep 30, 2020 at 11:55 PM Bastian Bittorf <bb@npl.de> wrote:
> >
> > Since 5.9-rc1 i can see false values, booting with qemu (128mb RAM):
> >
> > / # free
> >               total        used        free      shared  buff/cache available
> > Mem:         122176 18014398506028288      114848           0 3461024     3568096
> 
> that looks like a negative 64-bit number shifted down by 10 bits (bytes -> kB).
> 
> > / # cat /proc/meminfo | grep ^V
> > VmallocTotal:   34359738367 kB
> 
> .. but this part is normal. VMALLOC_TOTAL is the VM space for vmalloc
> areas, and it's large on a 64-bit machine.
> 
> And afaik, it hasn't changed in a long time.
> 
> So I think there's something else confusing 'free'.
> 
> I think it's this:
> 
> > / # cat /proc/meminfo
> > MemAvailable:    3617184 kB
> ..
> > Slab:           10321920 kB
> > SReclaimable:    3506176 kB
> > SUnreclaim:      6815744 kB
> 
> because those slab reclaimable/unreclaimable numbers look completely
> bogus. You have more unreclaimable slab space than you have memory.
> 
> Hmm. I'm not seeing anything similar. And your config looks sane, with
> the main difference I see wrt SLAB being that you have
> 
> # CONFIG_SLAB_MERGE_DEFAULT is not set
> 
> but there's nothing wrong with that either.
> 
> It would be lovely if you could bisect it, but maybe Vlastimil or
> Roman will go "Ahh, obviously.."
> 
>                  Linus

  reply	other threads:[~2020-10-01 19:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20201001065104.apevlkqrs6nid3r5@hp-nas.internet>
2020-10-01 19:19 ` Linus Torvalds
2020-10-01 19:56   ` Roman Gushchin [this message]
2020-10-01 19:58     ` Linus Torvalds
2020-10-01 20:39       ` Roman Gushchin
2020-10-02  0:08         ` [PATCH] mm: memcg/slab: fix slab statistics in !SMP configuration kernel test robot
2020-10-02  0:55           ` Roman Gushchin
2020-10-02  5:34             ` [kbuild-all] " Philip Li
2020-10-02 17:55               ` Roman Gushchin
2020-10-12 23:05                 ` Philip Li
2020-10-13  0:31                   ` Roman Gushchin
2020-10-02  7:01         ` Linux 5.9-rc7 / VmallocTotal wrongly reported | Patch OK Bastian Bittorf
2020-10-02 17:52           ` Roman Gushchin
2020-10-02  8:51         ` Linux 5.9-rc7 / VmallocTotal wrongly reported Vlastimil Babka
2020-10-02 21:43         ` [PATCH] mm: memcg/slab: fix slab statistics in !SMP configuration kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201001195610.GC2706729@carbon.DHCP.thefacebook.com \
    --to=guro@fb.com \
    --cc=akpm@linux-foundation.org \
    --cc=bb@npl.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®