From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9D44C46466 for ; Fri, 2 Oct 2020 22:28:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 90B2F20719 for ; Fri, 2 Oct 2020 22:28:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725801AbgJBW2c (ORCPT ); Fri, 2 Oct 2020 18:28:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725283AbgJBW2c (ORCPT ); Fri, 2 Oct 2020 18:28:32 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A718C0613D0; Fri, 2 Oct 2020 15:28:32 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 75BFB11E4824E; Fri, 2 Oct 2020 15:11:42 -0700 (PDT) Date: Fri, 02 Oct 2020 15:28:29 -0700 (PDT) Message-Id: <20201002.152829.1002796270145913943.davem@davemloft.net> To: colyli@suse.de Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, netdev@vger.kernel.org, open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org, ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org, chaitanya.kulkarni@wdc.com, cleech@redhat.com, hch@lst.de, amwang@redhat.com, eric.dumazet@gmail.com, hare@suse.de, idryomov@gmail.com, jack@suse.com, jlayton@kernel.org, axboe@kernel.dk, lduncan@suse.com, michaelc@cs.wisc.edu, mskorzhinskiy@solarflare.com, philipp.reisner@linbit.com, sagi@grimberg.me, vvs@virtuozzo.com, vbabka@suse.com Subject: Re: [PATCH v10 0/7] Introduce sendpage_ok() to detect misused sendpage in network related drivers From: David Miller In-Reply-To: <20201002082734.13925-1-colyli@suse.de> References: <20201002082734.13925-1-colyli@suse.de> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Fri, 02 Oct 2020 15:11:43 -0700 (PDT) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Coly Li Date: Fri, 2 Oct 2020 16:27:27 +0800 > As Sagi Grimberg suggested, the original fix is refind to a more common > inline routine: > static inline bool sendpage_ok(struct page *page) > { > return (!PageSlab(page) && page_count(page) >= 1); > } > If sendpage_ok() returns true, the checking page can be handled by the > concrete zero-copy sendpage method in network layer. Series applied. > The v10 series has 7 patches, fixes a WARN_ONCE() usage from v9 series, ... I still haven't heard from you how such a fundamental build failure was even possible. If the v9 patch series did not even compile, how in the world did you perform functional testing of these changes? Please explain this to me, instead of just quietly fixing it and posting an updated series. Thank you.