From: Mark Rutland <mark.rutland@arm.com>
To: Paul Bolle <pebolle@tiscali.nl>, Peter Zijlstra <peterz@infradead.org>
Cc: Will Deacon <will@kernel.org>, Boqun Feng <boqun.feng@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] locking/atomics: Check atomic-arch-fallback.h too
Date: Fri, 2 Oct 2020 14:00:08 +0100 [thread overview]
Message-ID: <20201002130008.GA2500@C02TD0UTHF1T.local> (raw)
In-Reply-To: <20201001202028.1048418-1-pebolle@tiscali.nl>
On Thu, Oct 01, 2020 at 10:20:28PM +0200, Paul Bolle wrote:
> The sha1sum of include/linux/atomic-arch-fallback.h isn't checked by
> check-atomics.sh. It's not clear why it's skipped so let's check it too.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
This was an oversight; Peter and I forgot to add this when Peter added
the arch fallbacks in commit:
37f8173dd84936ea ("locking/atomics: Flip fallbacks and instrumentation")
... for which we could arguably add a fixes tag.
Either way:
Reviewed-by: Mark Rutland <mark.rutland@arm.com>
Peter, I assume you'll pick this up (and also that the hash is
up-to-date as it should be).
> ---
> It seems it never has been checked. So this does cast some doubt about
> the usefulness of these tests. But I'm clueless about this atomic stuff
> so what do I know?
The tests have been useful to ensure people fixed up the scripts when
altering other files, so I think it makes sense to keep this even if we
did miss one file recently.
Mark.
>
> scripts/atomic/check-atomics.sh | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/atomic/check-atomics.sh b/scripts/atomic/check-atomics.sh
> index 8378c63a1e09..82748d42ecc5 100755
> --- a/scripts/atomic/check-atomics.sh
> +++ b/scripts/atomic/check-atomics.sh
> @@ -16,6 +16,7 @@ fi
> cat <<EOF |
> asm-generic/atomic-instrumented.h
> asm-generic/atomic-long.h
> +linux/atomic-arch-fallback.h
> linux/atomic-fallback.h
> EOF
> while read header; do
> --
> 2.26.2
>
next prev parent reply other threads:[~2020-10-02 13:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 20:20 Paul Bolle
2020-10-02 13:00 ` Mark Rutland [this message]
2020-10-07 16:20 ` [tip: locking/core] " tip-bot2 for Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201002130008.GA2500@C02TD0UTHF1T.local \
--to=mark.rutland@arm.com \
--cc=boqun.feng@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®