From: "Paul E. McKenney" <paulmck@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>,
kim.phillips@amd.com
Subject: Re: [PATCH] rcu,ftrace: Fix ftrace recursion
Date: Sun, 4 Oct 2020 17:18:56 -0700 [thread overview]
Message-ID: <20201005001856.GT29330@paulmck-ThinkPad-P72> (raw)
In-Reply-To: <20200929130449.12c474a5@gandalf.local.home>
On Tue, Sep 29, 2020 at 01:04:49PM -0400, Steven Rostedt wrote:
> On Tue, 29 Sep 2020 09:56:40 -0700
> "Paul E. McKenney" <paulmck@kernel.org> wrote:
>
> > > Well, I think we should actually apply both, but the comment needs to be
> > > updated, as it will no longer be outside recursion. And the comment is
> > > wrong now as well, as its only outside recursion protection for the
> > > assist_func().
> > >
> > > But it does prevent it from being always called for perf.
> > >
> > > * Make notrace because it can be called by the internal functions of
> > > * ftrace, and making this notrace removes unnecessary recursion calls.
> >
> > Fair enough. ;-)
> >
> > If I don't hear otherwise by late today (Tuesday), Pacific Time, I will
> > update the comment and pull it into -rcu. If you guys have some other
> > route to mainline in mind, you have my Reviewed-by. Either way, just
> > let me know.
>
> I'm currently testing the recursion fix and will push that to Linus when
> done. But you can take the comment update through your tree.
>
> Peter, are you OK if Paul changes your comment to what I suggested?
Hearing no objections, I have queued the patch with the comment updated
as suggested by Steven. Thank you all!
Thanx, Paul
next prev parent reply other threads:[~2020-10-05 0:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 11:33 Peter Zijlstra
2020-09-29 14:31 ` Paul E. McKenney
2020-09-29 14:36 ` Steven Rostedt
2020-09-29 14:41 ` Paul E. McKenney
2020-09-29 14:54 ` Steven Rostedt
2020-09-29 16:56 ` Paul E. McKenney
2020-09-29 17:04 ` Steven Rostedt
2020-10-05 0:18 ` Paul E. McKenney [this message]
2020-09-29 14:49 ` Peter Zijlstra
2020-09-29 15:19 ` Steven Rostedt
2020-09-29 14:43 ` Kim Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201005001856.GT29330@paulmck-ThinkPad-P72 \
--to=paulmck@kernel.org \
--cc=kim.phillips@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®