From: Daniel Wagner <dwagner@suse.de>
To: Nilesh Javali <njavali@marvell.com>, Arun Easi <aeasi@marvell.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] qla2xxx: Do not consume srb greedily
Date: Mon, 5 Oct 2020 09:42:54 +0200 [thread overview]
Message-ID: <20201005074254.2f5vgauk5tfwad35@beryllium.lan> (raw)
In-Reply-To: <20200929073802.18770-1-dwagner@suse.de>
On Tue, Sep 29, 2020 at 09:38:02AM +0200, Daniel Wagner wrote:
> qla2xx_process_get_sp_from_handle() will clear the slot which the
> current srb is stored. So this function has a side effect. Therefore,
> we can't use it in qla24xx_process_mbx_iocb_response() to check
> for consistency and later again in qla24xx_mbx_iocb_entry().
>
> Let's move the consistency check directly into
> qla24xx_mbx_iocb_entry() and avoid the double call or any open coding
> of the qla2xx_process_get_sp_from_handle() functionality.
>
> Fixes: 31a3271ff11b ("scsi: qla2xxx: Handle incorrect entry_type entries")
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
> Hi,
>
> Brown bag for me please. My test patch had an open coded version of
> qla2xx_process_get_sp_from_handle() which didn't consume the srb. When
> I prepared it for sending it out, I 'cleaned' it up by using
> qla2xx_process_get_sp_from_handle() twice.
Ping.
next prev parent reply other threads:[~2020-10-05 7:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 7:38 Daniel Wagner
2020-10-05 7:42 ` Daniel Wagner [this message]
2020-10-07 13:54 ` Himanshu Madhani
2020-10-07 17:05 ` Arun Easi
2020-10-08 2:19 ` Martin K. Petersen
2020-10-13 22:42 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201005074254.2f5vgauk5tfwad35@beryllium.lan \
--to=dwagner@suse.de \
--cc=aeasi@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=njavali@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®