From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05587C4363A for ; Mon, 5 Oct 2020 14:17:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 932F120757 for ; Mon, 5 Oct 2020 14:17:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="WT9po212" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726458AbgJEORA (ORCPT ); Mon, 5 Oct 2020 10:17:00 -0400 Received: from z5.mailgun.us ([104.130.96.5]:54645 "EHLO z5.mailgun.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726214AbgJEORA (ORCPT ); Mon, 5 Oct 2020 10:17:00 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1601907419; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Cc: To: From: Date: Sender; bh=gjIe2ygMMO0OxoF/7nC6agXSEHwLrd1WXB+jbD6E5Co=; b=WT9po212yoqhtF/1EXf/EbD+21Jxv5YuxmoQjYL9MNZyGN7Rmpw8T+U8UAgjVEGSHO3XW5pJ Vws7oPungIKUszrK2eEL5u+ti4MSMYuOgRm576YR0UQXv1Vm8Ny8MZbpqOKpfei6rzvKOuge zqOPC8BvQfTKUhv1hOAVGwlLHmw= X-Mailgun-Sending-Ip: 104.130.96.5 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-east-1.postgun.com with SMTP id 5f7b2acad63768e57be7c432 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 05 Oct 2020 14:16:42 GMT Sender: jcrouse=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 64A8BC433CA; Mon, 5 Oct 2020 14:16:41 +0000 (UTC) Received: from jcrouse1-lnx.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: jcrouse) by smtp.codeaurora.org (Postfix) with ESMTPSA id 43500C433C8; Mon, 5 Oct 2020 14:16:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 43500C433C8 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=jcrouse@codeaurora.org Date: Mon, 5 Oct 2020 08:16:36 -0600 From: Jordan Crouse To: Rob Clark Cc: dri-devel@lists.freedesktop.org, Rob Clark , "open list:DRM DRIVER FOR MSM ADRENO GPU" , David Airlie , "open list:DRM DRIVER FOR MSM ADRENO GPU" , open list , Daniel Vetter , Sean Paul Subject: Re: [Freedreno] [PATCH 03/14] drm/msm: Move update_fences() Message-ID: <20201005141636.GB4204@jcrouse1-lnx.qualcomm.com> Mail-Followup-To: Rob Clark , dri-devel@lists.freedesktop.org, Rob Clark , "open list:DRM DRIVER FOR MSM ADRENO GPU" , David Airlie , "open list:DRM DRIVER FOR MSM ADRENO GPU" , open list , Daniel Vetter , Sean Paul References: <20201004192152.3298573-1-robdclark@gmail.com> <20201004192152.3298573-4-robdclark@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201004192152.3298573-4-robdclark@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 04, 2020 at 12:21:35PM -0700, Rob Clark wrote: > From: Rob Clark > > Small cleanup, update_fences() is used in the hangcheck path, but also > in the normal retire path. Reviewed-by: Jordan Crouse > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/msm_gpu.c | 28 ++++++++++++++-------------- > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c > index 31fce3ac0cdc..ca8c95b32c8b 100644 > --- a/drivers/gpu/drm/msm/msm_gpu.c > +++ b/drivers/gpu/drm/msm/msm_gpu.c > @@ -265,6 +265,20 @@ int msm_gpu_hw_init(struct msm_gpu *gpu) > return ret; > } > > +static void update_fences(struct msm_gpu *gpu, struct msm_ringbuffer *ring, > + uint32_t fence) > +{ > + struct msm_gem_submit *submit; > + > + list_for_each_entry(submit, &ring->submits, node) { > + if (submit->seqno > fence) > + break; > + > + msm_update_fence(submit->ring->fctx, > + submit->fence->seqno); > + } > +} > + > #ifdef CONFIG_DEV_COREDUMP > static ssize_t msm_gpu_devcoredump_read(char *buffer, loff_t offset, > size_t count, void *data, size_t datalen) > @@ -411,20 +425,6 @@ static void msm_gpu_crashstate_capture(struct msm_gpu *gpu, > * Hangcheck detection for locked gpu: > */ > > -static void update_fences(struct msm_gpu *gpu, struct msm_ringbuffer *ring, > - uint32_t fence) > -{ > - struct msm_gem_submit *submit; > - > - list_for_each_entry(submit, &ring->submits, node) { > - if (submit->seqno > fence) > - break; > - > - msm_update_fence(submit->ring->fctx, > - submit->fence->seqno); > - } > -} > - > static struct msm_gem_submit * > find_submit(struct msm_ringbuffer *ring, uint32_t fence) > { > -- > 2.26.2 > > _______________________________________________ > Freedreno mailing list > Freedreno@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/freedreno -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project